When having a hook without specifying a sync wave (default) all resources are treated as hooks that needs checking on its health #715
Description
The current situation is that I have a helm chart that contains a simple Deployment and a job that is a hook.
Any updates to the deployment manifest, should update the deployment manifest right away, and create the job in parallel, given that no sync-waves are used to orchestrate between them.
My intuition tells me that
Sync Operation Should only be marked as Running until the hook/job succeeds
and the deployment should not be part of it. if the manifest was applied successfully. It's up to the application health status to report if it is still progressing/healthy/degraded not the sync operation.
I feel like when there are hooks in the same sync wave with other resources that are not hooks. Only hooks should only be the only resources checked for it's health before marking Sync as completed. However, other non-hook resources should be applied async just the same behavior when no hooks are specified in the sync wave given that this is the last wave ofc.
I could be missing something here. But I would like to understand more about the reasoning behind having non-hook resources checked for their health if there is a hook in the same wave even if it's the last sync wave and phase.