Skip to content

Commit 0ee8bba

Browse files
authored
Improve KafkaErrorException message (#555)
1 parent 554305b commit 0ee8bba

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

kafka_error_exception.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ void create_kafka_error(zval *return_value, const rd_kafka_error_t *error) /* {{
3939
{
4040
object_init_ex(return_value, ce_kafka_error);
4141

42-
zend_update_property_string(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("message"), rd_kafka_error_name(error));
42+
zend_string *message = zend_strpprintf(0, "%s (RD_KAFKA_RESP_ERR_%s)", rd_kafka_error_string(error), rd_kafka_error_name(error));
43+
zend_update_property_str(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("message"), message);
44+
zend_string_release(message);
45+
4346
zend_update_property_long(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("code"), rd_kafka_error_code(error));
4447
zend_update_property_string(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("error_string"), rd_kafka_error_string(error));
4548
zend_update_property_bool(ce_kafka_error, Z_RDKAFKA_PROP_OBJ(return_value), ZEND_STRL("isFatal"), rd_kafka_error_is_fatal(error));

tests/init_transaction_not_configured.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ try {
2929
}
3030

3131
--EXPECTF--
32-
_NOT_CONFIGURED
32+
The Transactional API requires transactional.id to be configured (RD_KAFKA_RESP_ERR__NOT_CONFIGURED)
3333
-145
3434
%s/tests/init_transaction_not_configured.php
3535
14

0 commit comments

Comments
 (0)