Try to make Rubocop happy

Author: johvet

lib/jsonapi/active_model_error_serializer.rb

@@ -5,8 +5,10 @@ module JSONAPI
   class ActiveModelErrorSerializer < ErrorSerializer
     class << self
       ##
-      # Get the status code to render for the serializer, considering an
-      # eventual status provided through the serializer parameters
+      # Get the status code to render for the serializer
+      #
+      # This considers an optional status provided through the serializer
+      # parameters, as either a symbol or a number.
       #
       # @param params [Hash]
       #     The serializer parameters
@@ -72,7 +74,7 @@ def status_code(params)
       elsif rels.include?(error_key)
         { pointer: "/data/relationships/#{error_key}" }
       elsif error_key == :base
-        { pointer: "/data" }
+        { pointer: '/data' }
       else
         { pointer: nil }
       end

lib/jsonapi/rails.rb

@@ -73,7 +73,8 @@ def self.add_errors_renderer!
 
                 details[attr] << current
               else
-                details[attr] << error.merge(message: resource.messages[attr][index])
+                message = resource.messages[attr][index]
+                details[attr] << error.merge(message: message)
               end
             end
           end
@@ -92,7 +93,11 @@ def self.add_errors_renderer!
 
         JSONAPI::Rails.serializer_to_json(
           JSONAPI::ActiveModelErrorSerializer.new(
-            errors, params: { model: model, model_serializer: model_serializer, status: options[:status] }
+            errors, params: {
+              model:            model,
+              model_serializer: model_serializer,
+              status:           options[:status]
+            }
           )
         )
       end

spec/dummy.rb

@@ -57,7 +57,10 @@ def self.ransackable_attributes(auth_object = nil)
 
   # Provide a validation adding an error to the model's base
   def title_check
-    errors.add(:base, :model_invalid, errors: 'The record has an unacceptable title.') if title == 'n/a'
+    return unless title == 'n/a'
+
+    message = 'The record has an unacceptable title.'
+    errors.add(:base, :model_invalid, errors: message)
   end
 
   def deletable?