Validation errors on the model instance should return the correct pointer value

Author: johvet

lib/jsonapi/active_model_error_serializer.rb

@@ -49,6 +49,8 @@ class ActiveModelErrorSerializer < ErrorSerializer
         { pointer: "/data/attributes/#{error_key}" }
       elsif rels.include?(error_key)
         { pointer: "/data/relationships/#{error_key}" }
+      elsif error_key == :base
+        { pointer: "/data" }
       else
         { pointer: '' }
       end

spec/dummy.rb

@@ -43,6 +43,7 @@ def self.ransackable_associations(auth_object = nil)
 class Note < ActiveRecord::Base
   validates_format_of :title, without: /BAD_TITLE/
   validates_numericality_of :quantity, less_than: 100, if: :quantity?
+  validate :title_check
   belongs_to :user, required: true
 
   def self.ransackable_associations(auth_object = nil)
@@ -52,6 +53,11 @@ def self.ransackable_associations(auth_object = nil)
   def self.ransackable_attributes(auth_object = nil)
     %w(created_at id quantity title updated_at user_id)
   end
+
+  # Provide a validation adding an error to the model's base
+  def title_check
+    errors.add(:base, :invalid) if title == 'n/a'
+  end
 end
 
 class CustomNoteSerializer

spec/errors_spec.rb

@@ -138,6 +138,27 @@
             .to eq('pointer' => '/data/attributes/title')
         end
       end
+
+      context 'with a validation error on the class' do
+        let(:params) do
+          payload = note_params.dup
+          payload[:data][:attributes][:title] = 'n/a'
+          payload
+        end
+
+        it do
+          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response_json['errors'].size).to eq(1)
+          expect(response_json['errors'][0]['status']).to eq('422')
+          expect(response_json['errors'][0]['code']).to include('invalid')
+          expect(response_json['errors'][0]['title'])
+            .to eq(Rack::Utils::HTTP_STATUS_CODES[422])
+          expect(response_json['errors'][0]['source'])
+              .to eq('pointer' => '/data')
+          expect(response_json['errors'][0]['detail'])
+            .to eq('is invalid')
+        end
+      end
     end
 
     context 'with a bad note ID' do