Refactors constraints to use named arguments

Adopts named arguments for Symfony Validator constraint instantiation within field providers and their corresponding tests.

This improves code readability and explicitness by clearly labeling each argument's purpose, making the constraint configuration easier to understand.

Author: sylfabre

src/Validator/Constraints/Email.php

@@ -21,14 +21,25 @@ class Email extends _Email
     public bool $checkDNS = false;
 
     public function __construct(
-        ?array $options = null,
         ?string $message = null,
         ?string $mode = null,
         ?callable $normalizer = null,
         ?array $groups = null,
         mixed $payload = null,
+        ?string $tldMessage = null,
+        ?string $dnsMessage = null,
+        ?bool $checkDNS = null,
     ) {
-        parent::__construct($options, $message, $mode, $normalizer, $groups, $payload);
+        parent::__construct(message: $message, mode: $mode, normalizer: $normalizer, groups: $groups, payload: $payload);
         $this->mode ??= 'strict';
+        if (null !== $tldMessage) {
+            $this->tldMessage = $tldMessage;
+        }
+        if (null !== $dnsMessage) {
+            $this->dnsMessage = $dnsMessage;
+        }
+        if (null !== $checkDNS) {
+            $this->checkDNS = $checkDNS;
+        }
     }
 }

src/Validator/Constraints/EntityValidator.php

@@ -131,7 +131,7 @@ public function getConstraints(string $class, string $field): array
                     }
                 } elseif (($fieldMapping['type'] & ClassMetadataInfo::TO_MANY) !== 0) {
                     // ToMany
-                    $constraints[] = new All([
+                    $constraints[] = new All(constraints: [
                         new Type($fieldMapping['targetEntity']),
                     ]);
                 } else {

src/Validator/Constraints/FloatScale.php

@@ -18,32 +18,12 @@ class FloatScale extends Constraint
 
     public int $scale;
 
-    /**
-     * @param int|array<mixed> $scale
-     * @param array<mixed> $options
-     */
     public function __construct(
-        $scale,
+        int $scale,
         ?array $groups = null,
         mixed $payload = null,
-        array $options = []
     ) {
-        if (\is_array($scale)) {
-            $options = array_merge($scale, $options);
-        } elseif (null !== $scale) {
-            $options['value'] = $scale;
-        }
-
-        parent::__construct($options, $groups, $payload);
-    }
-
-    public function getDefaultOption(): string
-    {
-        return 'scale';
-    }
-
-    public function getRequiredOptions(): array
-    {
-        return ['scale'];
+        $this->scale = $scale;
+        parent::__construct(groups: $groups, payload: $payload);
     }
 }

src/Validator/Constraints/Money.php

@@ -16,4 +16,15 @@ class Money extends Constraint
 
     public float $min = 0.0;
     public float $max = self::MAX;
+
+    public function __construct(
+        float $min = 0.0,
+        float $max = self::MAX,
+        ?array $groups = null,
+        mixed $payload = null,
+    ) {
+        parent::__construct(groups: $groups, payload: $payload);
+        $this->min = $min;
+        $this->max = $max;
+    }
 }

src/Validator/Constraints/Postal.php

@@ -16,33 +16,13 @@ class Postal extends Constraint
 
     public string $countryPropertyPath;
 
-    /**
-     * @param string|array<mixed> $countryPropertyPath
-     * @param array<mixed> $options
-     */
     public function __construct(
-        $countryPropertyPath,
+        string $countryPropertyPath,
         ?array $groups = null,
         mixed $payload = null,
-        array $options = []
     ) {
-        if (\is_array($countryPropertyPath)) {
-            $options = array_merge($countryPropertyPath, $options);
-        } elseif (null !== $countryPropertyPath) {
-            $options['value'] = $countryPropertyPath;
-        }
-
-        parent::__construct($options, $groups, $payload);
-    }
-
-    public function getDefaultOption(): string
-    {
-        return 'countryPropertyPath';
-    }
-
-    public function getRequiredOptions(): array
-    {
-        return ['countryPropertyPath'];
+        $this->countryPropertyPath = $countryPropertyPath;
+        parent::__construct(groups: $groups, payload: $payload);
     }
 
     public string $message = 'The value {{ value }} is not a valid postal code.';

src/Validator/ConstraintsSetProvider/Field/EmailProvider.php

@@ -19,7 +19,7 @@ public function getConstraints(array $fieldMapping): array
     {
         return [
             new Email(),
-            new Length(['max' => ($fieldMapping['length'] ?? 255)]),
+            new Length(max: $fieldMapping['length'] ?? 255),
         ];
     }
 }

src/Validator/ConstraintsSetProvider/Field/IpProvider.php

@@ -17,7 +17,7 @@ public function supports(string $type): bool
     public function getConstraints(array $fieldMapping): array
     {
         return [
-            new Ip(['version' => 'all']),
+            new Ip(version: 'all'),
         ];
     }
 }

src/Validator/ConstraintsSetProvider/Field/LocaleProvider.php

@@ -17,7 +17,7 @@ public function supports(string $type): bool
     public function getConstraints(array $fieldMapping): array
     {
         return [
-            new Locale(['canonicalize' => true]),
+            new Locale(canonicalize: true),
         ];
     }
 }

src/Validator/ConstraintsSetProvider/Field/StringProvider.php

@@ -17,10 +17,10 @@ public function supports(string $type): bool
 
     public function getConstraints(array $fieldMapping): array
     {
-        $constraints = [new Length(['max' => $fieldMapping['length'] ?? 255])];
+        $constraints = [new Length(max: $fieldMapping['length'] ?? 255)];
 
         if (isset($fieldMapping['nullable']) && true === $fieldMapping['nullable']) {
-            $constraints[] = new NotBlank(['allowNull' => true]);
+            $constraints[] = new NotBlank(allowNull: true);
         }
 
         return $constraints;

src/Validator/ConstraintsSetProvider/Field/TextProvider.php

@@ -17,10 +17,7 @@ public function supports(string $type): bool
     public function getConstraints(array $fieldMapping): array
     {
         return [
-            new Length([
-                'max' => $fieldMapping['length'] ?? 65535,
-                'charset' => '8bit',
-            ]),
+            new Length(max: $fieldMapping['length'] ?? 65535, charset: '8bit'),
         ];
     }
 }