Upgrade phpstan (#1793)

Author: jderusse

src/Generator/OperationGenerator.php

@@ -116,9 +116,8 @@ public function generate(Operation $operation): void
             $method->addComment('@see ' . $documentation);
         }
         $method->addComment('@see ' . $operation->getApiReferenceDocumentationUrl());
-        if (null !== $prefix = $operation->getService()->getEndpointPrefix()) {
-            $method->addComment('@see https://docs.aws.amazon.com/aws-sdk-php/v3/api/api-' . $prefix . '-' . $operation->getService()->getApiVersion() . '.html#' . strtolower($operation->getName()));
-        }
+        $prefix = $operation->getService()->getEndpointPrefix();
+        $method->addComment('@see https://docs.aws.amazon.com/aws-sdk-php/v3/api/api-' . $prefix . '-' . $operation->getService()->getApiVersion() . '.html#' . strtolower($operation->getName()));
         [$doc, $memberClassNames] = $this->typeGenerator->generateDocblock($inputShape, $inputClass, true, false, false, ['  \'@region\'?: string|null,']);
         $method->addComment($doc);
         foreach ($memberClassNames as $memberClassName) {

src/Generator/ResponseParser/RestXmlParser.php

@@ -366,12 +366,10 @@ private function createPopulateMethod(string $functionName, string $body, Shape
                 ->setType(\SimpleXMLElement::class)
         ;
 
-        if (null !== $shape) {
-            [$returnType, $parameterType, $memberClassNames] = $this->typeGenerator->getPhpType($shape);
-            $method
-                ->setComment('@return ' . $parameterType);
-            $this->imports = array_merge($this->imports, $memberClassNames);
-        }
+        [$returnType, $parameterType, $memberClassNames] = $this->typeGenerator->getPhpType($shape);
+        $method
+            ->setComment('@return ' . $parameterType);
+        $this->imports = array_merge($this->imports, $memberClassNames);
 
         return $method;
     }

src/Generator/TestGenerator.php

@@ -102,7 +102,7 @@ private function generateInput(Operation $operation, StructureShape $shape): voi
 
                 break;
             case 'query':
-                $stub = substr(var_export($exampleInput ? (\is_array($exampleInput) ? http_build_query($exampleInput, '', '&', \PHP_QUERY_RFC3986) : $exampleInput) : "
+                $stub = substr(var_export($exampleInput ? http_build_query($exampleInput, '', '&', \PHP_QUERY_RFC3986) : "
     Action={$operation->getName()}
     &Version={$operation->getApiVersion()}
 ", true), 1, -1);