Allow passing explicit null values for optional input members (#1542)

This makes it easier to define the array literal for input objects as
PHP does not have a syntax sugar for conditional keys in an array
literal. This is consistent with the generated code for value objects.

Even though input objects allow to omit required members in the
constructor shape (as they can be set later by using the setter), the
phpdoc type still does not allow passing null explicitly (even though
the code would deal with it until the validation run) so that static
analysis tools can catch mistakes there. Passing a required member
explicitly is intended to pass a valid value for it and not a
potentially missing one.

Author: stof

src/Generator/CodeGenerator/TypeGenerator.php

@@ -103,12 +103,12 @@ public function generateDocblock(StructureShape $shape, ClassName $shapeClassNam
                 }
             }
 
-            if ($allNullable || $nullable) {
-                if ($isObject) {
-                    $body[] = sprintf('  %s?: %s,', $member->getName(), 'null|' . $param);
-                } else {
-                    $body[] = sprintf('  %s?: %s,', $member->getName(), $param);
-                }
+            if ($nullable) {
+                $body[] = sprintf('  %s?: %s,', $member->getName(), 'null|' . $param);
+            } elseif ($allNullable) {
+                // For input objects, the constructor allows to omit all members to set them later. But when provided,
+                // they should respect the nullability of the member.
+                $body[] = sprintf('  %s?: %s,', $member->getName(), $param);
             } else {
                 $body[] = sprintf('  %s: %s,', $member->getName(), $param);
             }