mac-media-keys: Remove plugin

It was unmaintained for years, uses many deprecated symbols,
crashes immediately on start-up on my MacBook and was never
enabled by default (both build- and runtime). The new macOS
plugin "Now Playing" (commit d71db57) serves as successor.

Author: radioactiveman

.github/actions/run-action/run-action.sh

@@ -45,12 +45,12 @@ case "$action" in
         export PKG_CONFIG_PATH="/usr/local/opt/qt@5/lib/pkgconfig:$PKG_CONFIG_PATH"
 
         if [ "$build_system" = 'meson' ]; then
-          meson setup build -D qt5=true -D gtk=false -D mac-media-keys=true
+          meson setup build -D qt5=true -D gtk=false
         else
           export LDFLAGS="-L/usr/local/opt/libiconv/lib"
           export CPPFLAGS="-I/usr/local/opt/libiconv/include"
           autoreconf -I "/usr/local/share/gettext/m4" &&
-          ./configure --enable-qt5 --disable-gtk --enable-mac-media-keys
+          ./configure --enable-qt5 --disable-gtk
         fi
         ;;
 
@@ -59,12 +59,12 @@ case "$action" in
         export PKG_CONFIG_PATH="/opt/homebrew/opt/qt@6/libexec/lib/pkgconfig:$PKG_CONFIG_PATH"
 
         if [ "$build_system" = 'meson' ]; then
-          meson setup build -D gtk=false -D mac-media-keys=true
+          meson setup build -D gtk=false
         else
           export LDFLAGS="-L/opt/homebrew/opt/libiconv/lib"
           export CPPFLAGS="-I/opt/homebrew/opt/libiconv/include"
           autoreconf -I "/opt/homebrew/opt/gettext/share/gettext/m4" &&
-          ./configure --disable-gtk --enable-mac-media-keys
+          ./configure --disable-gtk
         fi
         ;;
 

configure.ac

@@ -709,19 +709,8 @@ fi
 AC_SUBST(FILEWRITER_CFLAGS)
 AC_SUBST(FILEWRITER_LIBS)
 
-dnl Mac Media Keys
-dnl ============
-
-AC_ARG_ENABLE(mac_media_keys,
- [AS_HELP_STRING([--enable-mac-media-keys], [enable Mac Media Keys])],
- [enable_mac_media_keys=$enableval], [enable_mac_media_keys="no"])
-
-if test "x$enable_mac_media_keys" != "xno"; then
-    GENERAL_PLUGINS="$GENERAL_PLUGINS mac-media-keys"
-fi
-
 dnl Mac Now Playing
-dnl ============
+dnl ===============
 
 AC_ARG_ENABLE(mac_now_playing,
  [AS_HELP_STRING([--disable-mac-now-playing], [disable Mac Now Playing (default=enabled)])],
@@ -930,7 +919,6 @@ if test "x$HAVE_DARWIN" = "xyes" ; then
     echo "  macOS Support"
     echo "  -------------"
     echo "  CoreAudio output:                       $have_coreaudio"
-    echo "  Media Keys:                             $enable_mac_media_keys"
     echo "  Now Playing:                            $enable_mac_now_playing"
     echo
 fi

meson.build

@@ -351,7 +351,6 @@ if meson.version().version_compare('>= 0.53')
   if have_darwin
     summary({
       'CoreAudio Output': get_option('coreaudio'),
-      'Media Keys': get_option('mac-media-keys'),
       'Now Playing': get_option('mac-now-playing'),
     }, section: 'macOS Support')
   endif

meson_options.txt

@@ -94,8 +94,6 @@ option('hotkey', type: 'boolean', value: true,
        description: 'Whether the global hotkey plugin (X11) is enabled')
 option('lirc', type: 'boolean', value: true,
        description: 'Whether the LIRC plugin is enabled')
-option('mac-media-keys', type: 'boolean', value: false,
-       description: 'Whether the Mac Media Keys plugin is enabled')
 option('mac-now-playing', type: 'boolean', value: true,
        description: 'Whether the Mac Now Playing plugin is enabled')
 option('mpris2', type: 'boolean', value: true,