Skip to content

[backport] OAuth build-time credentials + docs (upstream main) #12

Description

@gastrodon

Summary

Completes the OAuth feature with build infrastructure and user-facing documentation:

  • internal/buildinfo/buildinfo.go: exports DefaultOAuthClientID and DefaultOAuthClientSecret vars injected at link time via goreleaser -ldflags from repo secrets OAUTH_CLIENT_ID/OAUTH_CLIENT_SECRET
  • Official binaries ship zero-config defaults; local dev builds require --oauth-client-id
  • docs/oauth-login.md: dedicated guide covering PKCE/device flows, display channels, URL-elicitation security advisory, Docker fixed-port recipe, BYO-app, and GHES requirements
  • README.md and server.json updated: PAT made optional, OAuth callback port published, Docker install badges updated to use OAuth-first workflow
  • NormalizeHost exported from internal/oauth so github.com host aliases still receive the baked-in client

Upstream reference

Fork conflict

None. internal/buildinfo is new. server.json and docs are not part of the fork's custom tools.

Context

Without baked-in credentials, every user of official binaries would need to register their own OAuth app. The ldflags injection makes the official image truly zero-config while leaving dev builds explicit.

Depends on

See parent issue (OAuth story).

Metadata

Metadata

Assignees

No one assigned

    Labels

    backportBackport from upstreamfeatureNew featureno-opFork already has equivalent functionality

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions