Use common logic for working?

Author: Vidas P

.rubocop

@@ -34,12 +34,6 @@ Lint/AmbiguousBlockAssociation:
   Enabled: false
 Style/MethodCallWithoutArgsParentheses:
   Enabled: false
-Rails/TimeZone:
-  Enabled: false
-Rails/Date:
-  Enabled: false
-Rails/OutputSafety:
-  Enabled: false
 Layout/TrailingWhitespace:
   Enabled: false
 Style/ClassAndModuleChildren:
@@ -50,13 +44,8 @@ Style/FormatStringToken:
   Enabled: false
 Style/RescueModifier:
   Enabled: false
-Rails/Blank:
-  Enabled: false
 Metrics/BlockNesting:
   Enabled: false
-Rails/Present:
-  Enabled: false
-
 
 # Temporary disable method size metrics
 Metrics/AbcSize:

.rubocop.yml

@@ -112,9 +112,21 @@ def receive_web_request(_params, _method, _format)
   # def receive_web_request(request=ActionDispatch::Request.new( ... ))
   # end
 
-  # Implement me in your subclass to decide if your Agent is working.
   def working?
-    raise 'Implement me in your subclass'
+    return false if recent_error_logs?
+
+    return false unless received_message_without_error? || checked_without_error? || last_error_log_at.nil?
+
+    # Timeouts
+    if interpolated['expected_update_period_in_days'].present?
+      return false unless message_created_within?(interpolated['expected_update_period_in_days'])
+    end
+
+    if interpolated['expected_receive_period_in_days'].present?
+      return false unless last_receive_at && last_receive_at > interpolated['expected_receive_period_in_days'].to_i.days.ago
+    end
+
+    true
   end
 
   def build_message(message)

app/models/agent.rb

@@ -90,10 +90,6 @@ def default_options
         'path' => 'trackings' }
     end
 
-    def working?
-      !recent_error_logs?
-    end
-
     def validate_options
       errors.add(:base, 'You need to specify a api key') unless options['api_key'].present?
       errors.add(:base, 'You need to specify a path request') unless options['path'].present?

app/models/agents/aftership_agent.rb

@@ -49,10 +49,6 @@ def validate_options
       end
     end
 
-    def working?
-      message_created_within?(interpolated['expected_update_period_in_days']) && !recent_error_logs?
-    end
-
     def receive(incoming_messages)
       incoming_messages.each do |message|
         handle(interpolated(message), message)

app/models/agents/attribute_difference_agent.rb

@@ -57,10 +57,6 @@ def validate_options
       errors.add(:base, 'you need to specify the basecamp project id of which you want to receive messages') unless options['project_id'].present?
     end
 
-    def working?
-      (messages_count.present? && messages_count > 0)
-    end
-
     def check
       service.prepare_request
       response = HTTParty.get messages_url, request_options.merge(query_parameters)

app/models/agents/basecamp_agent.rb

@@ -55,10 +55,6 @@ def validate_options
     end
     # rubocop:enable Metrics/CyclomaticComplexity
 
-    def working?
-      last_receive_at && last_receive_at > options['expected_receive_period_in_days'].to_i.days.ago && !recent_error_logs?
-    end
-
     def receive(incoming_messages)
       incoming_messages.each do |message|
         memory['message_ids'] ||= []

app/models/agents/buffer_agent.rb

@@ -37,10 +37,6 @@ def validate_options
       end
     end
 
-    def working?
-      message_created_within?(interpolated['expected_update_period_in_days']) && !recent_error_logs?
-    end
-
     def receive(incoming_messages)
       incoming_messages.each do |message|
         interpolation_context.stack do

app/models/agents/change_detector_agent.rb

@@ -28,10 +28,6 @@ class CommanderAgent < Agent
       Select Agents that you want to control from this CommanderAgent.
     MD
 
-    def working?
-      true
-    end
-
     def check
       control!
     end

app/models/agents/commander_agent.rb

@@ -86,10 +86,6 @@ def validate_options
       end
     end
 
-    def working?
-      received_message_without_error?
-    end
-
     def receive(incoming_messages)
       case options['mode']
       when 'parse'