Drop 3rd-party service agents

* Remove third party service agents:
  - Remove Twilio agents.
  - Remove Slack agent.
  - Remove Evernote agent.
  - Remove S3 agent.
  - Remove Aftership, Basecamp and Jira agents.
* Remove unused gems.
* Remove OAuth services used by 3rd party agents.
* Fix TLS Check agent message description.

Author: raspberry-lef

CHANGELOG.md

@@ -9,6 +9,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - Replace agent type dropdown with card based selector.
 
+### Removed
+Removed third party agents:
+- Twilio agents.
+- Slack agent.
+- Evernote agent.
+- S3 agent.
+- Aftership agent.
+- Basecamp agent.
+- Jira agent.
+
 
 ## [0.9.13] - 2021-01-15
 ### Added

Gemfile

@@ -5,21 +5,7 @@ ruby '>=2.6.0'
 # Optional libraries.  To conserve RAM, comment out any that you don't need,
 # then run `bundle` and commit the updated Gemfile and Gemfile.lock.
 # TODO: update
-gem 'twilio-ruby', '~> 3.11.5'    # TwilioAgent
 gem 'net-ftp-list', '~> 3.2.8'    # FtpsiteAgent
-# TODO: update
-gem 'slack-notifier', '~> 1.0.0'  # SlackAgent
-
-# Evernote agent
-gem 'omniauth-evernote', '~> 1.2.1'
-gem 'evernote_oauth', '~> 0.2.3'
-
-# S3Agent
-# TODO: update
-gem 'aws-sdk-core', '~> 2.2.15'
-
-# Basecamp agent
-gem 'omniauth-37signals', '~> 1.0.5'
 
 gem 'ace-rails-ap', '~> 4.4'
 gem 'bootsnap', '>= 1.5.1', require: false
@@ -48,7 +34,6 @@ gem 'liquid', '~> 4.0.3'
 gem 'loofah', '~> 2.8.0'
 gem 'mini_magick', '~> 4.11.0'
 gem 'nokogiri', '~> 1.11.1'
-gem 'omniauth', '~> 1.9.1'
 gem 'rack-timeout', '~> 0.6.0'
 gem 'rails', '~> 6.0.3.4'
 gem 'rails-html-sanitizer', '~> 1.3.0'

Gemfile.lock

@@ -62,8 +62,6 @@ GEM
     ast (2.4.0)
     autoprefixer-rails (10.0.3.0)
       execjs
-    aws-sdk-core (2.2.37)
-      jmespath (~> 1.0)
     bcrypt (3.1.16)
     better_errors (2.7.0)
       coderay (>= 1.0.0)
@@ -159,10 +157,6 @@ GEM
     ethon (0.12.0)
       ffi (>= 1.3.0)
     eventmachine (1.2.7)
-    evernote-thrift (1.25.2)
-    evernote_oauth (0.2.3)
-      evernote-thrift
-      oauth (>= 0.4.1)
     execjs (2.7.0)
     faraday (0.17.3)
       multipart-post (>= 1.2, < 3)
@@ -213,7 +207,6 @@ GEM
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
     hashdiff (1.0.1)
-    hashie (3.6.0)
     http_parser.rb (0.6.0)
     httparty (0.18.1)
       mime-types (~> 3.0)
@@ -222,7 +215,6 @@ GEM
       concurrent-ruby (~> 1.0)
     iniparse (1.5.0)
     jaro_winkler (1.5.4)
-    jmespath (1.4.0)
     jquery-datatables (1.10.20)
     jquery-rails (4.4.0)
       rails-dom-testing (>= 1, < 3)
@@ -298,29 +290,6 @@ GEM
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    oauth (0.5.4)
-    oauth2 (1.4.4)
-      faraday (>= 0.8, < 2.0)
-      jwt (>= 1.0, < 3.0)
-      multi_json (~> 1.3)
-      multi_xml (~> 0.5)
-      rack (>= 1.2, < 3)
-    omniauth (1.9.1)
-      hashie (>= 3.4.6)
-      rack (>= 1.6.2, < 3)
-    omniauth-37signals (1.0.5)
-      omniauth (~> 1.0)
-      omniauth-oauth2 (~> 1.0)
-    omniauth-evernote (1.2.1)
-      evernote-thrift
-      multi_json (~> 1.0)
-      omniauth-oauth (~> 1.0)
-    omniauth-oauth (1.1.0)
-      oauth
-      omniauth (~> 1.0)
-    omniauth-oauth2 (1.6.0)
-      oauth2 (~> 1.1)
-      omniauth (~> 1.9)
     orm_adapter (0.5.0)
     overcommit (0.53.0)
       childprocess (>= 0.6.3, < 4)
@@ -471,7 +440,6 @@ GEM
       docile (~> 1.1)
       simplecov-html (~> 0.11)
     simplecov-html (0.12.2)
-    slack-notifier (1.0.0)
     spectrum-rails (1.8.0)
       railties (>= 3.1)
     sprockets (4.0.2)
@@ -486,10 +454,6 @@ GEM
     thread_safe (0.3.6)
     tilt (2.0.10)
     timecop (0.9.2)
-    twilio-ruby (3.11.6)
-      builder (>= 2.1.2)
-      jwt (>= 0.1.2)
-      multi_json (>= 1.3.0)
     typhoeus (1.4.0)
       ethon (>= 0.9.0)
     tzinfo (1.2.8)
@@ -523,7 +487,6 @@ PLATFORMS
 DEPENDENCIES
   ace-rails-ap (~> 4.4)
   addressable (~> 2.7.0)
-  aws-sdk-core (~> 2.2.15)
   better_errors (~> 2.7.0)
   binding_of_caller (~> 0.8.0)
   bootsnap (>= 1.5.1)
@@ -539,7 +502,6 @@ DEPENDENCIES
   delorean (~> 2.1.0)
   devise (~> 4.7.3)
   dotenv (~> 2.7.6)
-  evernote_oauth (~> 0.2.3)
   execjs (~> 2.7.0)
   faraday (~> 0.9)
   faraday_middleware (~> 0.12.2)
@@ -567,9 +529,6 @@ DEPENDENCIES
   mini_racer (~> 0.3.1)
   net-ftp-list (~> 3.2.8)
   nokogiri (~> 1.11.1)
-  omniauth (~> 1.9.1)
-  omniauth-37signals (~> 1.0.5)
-  omniauth-evernote (~> 1.2.1)
   overcommit (~> 0.53.0)
   pg (~> 1.2.3)
   pry-byebug (~> 3.9.0)
@@ -594,12 +553,10 @@ DEPENDENCIES
   select2-rails (~> 3.5.4)
   selenium-webdriver (~> 3.142.7)
   shoulda-matchers (~> 4.3.0)
-  slack-notifier (~> 1.0.0)
   spectrum-rails (~> 1.8.0)
   sprockets (~> 4.0.2)
   sqlite3 (~> 1.4.2)
   timecop (~> 0.9.2)
-  twilio-ruby (~> 3.11.5)
   typhoeus (~> 1.4.0)
   uglifier (~> 4.2.0)
   vcr (~> 5.1.0)

app/assets/javascripts/pages/agent-edit-page.js

@@ -162,12 +162,7 @@
           }
 
           if (!firstTime) {
-            if (json.oauthable) {
-              $(".oauthable-form").html(json.oauthable);
-            }
-            if (json.form_options) {
-              $(".agent-options").html(json.form_options);
-            }
+            if (json.form_options) { $('.agent-options').html(json.form_options); }
           }
 
           this.enableDryRunButton();

app/assets/javascripts/pages/services-index-page.js

@@ -162,53 +162,10 @@ nav .nav-item .nav-link:focus,
   // TODO
 }
 
-$service-colors: (
-  twitter:      #55acee,
-  37signals:    #8fc857,
-  github:       #444444,
-  dropbox:      #007EE5,
-  evernote:     #00C85A
-);
-
-@mixin services {
-  @each $service, $color in $service-colors {
-    &.service-#{$service} {
-      color: #fff;
-      background-color: $color;
-    }
-  }
-}
-
-.btn-service {
-  position: relative;
-  padding-left: 40px;
-  $border-color: rgba(0,0,0,0.2);
-  border-color: $border-color;
-
-  > i:first-child {
-    position: absolute;
-    top: 0;
-    left: 0;
-    bottom: 0;
-    width: 32px;
-    height: 32px;
-    text-align: center;
-    line-height: 32px;
-    font-size: 24px;
-    border-right: 1px solid $border-color;
-  }
-
-  @include services;
-}
-
 h1 .badge {
   text-shadow: none;
 }
 
-.badge-service {
-  @include services;
-}
-
 .select2-highlighted a {
   color: yellow;
   text-decoration: underline;

app/assets/stylesheets/general.scss

@@ -91,7 +91,6 @@ def type_details
       can_dry_run: @agent.can_dry_run?,
       options: @agent.default_options,
       description_html: @agent.html_description,
-      oauthable: render_to_string(partial: 'oauth_dropdown', locals: { agent: @agent }),
       form_options: render_to_string(partial: 'options', locals: { agent: @agent })
     }
   end

app/concerns/evernote_concern.rb

@@ -34,7 +34,7 @@ def upgrade_warning
   def agent_params
     return {} unless params[:agent]
     @agent_params ||= begin
-      params[:agent].permit([:memory, :name, :type, :schedule, :disabled, :keep_messages_for, :drop_pending_messages, :service_id,
+      params[:agent].permit([:memory, :name, :type, :schedule, :disabled, :keep_messages_for, :drop_pending_messages,
                              source_ids: [], receiver_ids: [], workflow_ids: [], controller_ids: [], control_target_ids: []] + agent_params_options)
     end
   end