Remove cookie based agent hiding

Author: Vidas P

app/controllers/agents_controller.rb

@@ -6,8 +6,6 @@ class AgentsController < ApplicationController
   def index
     @agents = current_user.agents.includes(:receivers)
 
-    @agents = @agents.where(disabled: false) if show_only_enabled_agents?
-
     # Trigger undefined agents handling.
     @agents.map { |agent| agent } if current_user.undefined_agent_types
 
@@ -57,16 +55,6 @@ def table
     render json: rows
   end
 
-  def toggle_visibility
-    if show_only_enabled_agents?
-      mark_all_agents_viewable
-    else
-      set_only_enabled_agents_as_viewable
-    end
-
-    redirect_to agents_path
-  end
-
   def handle_details_post
     @agent = current_user.agents.find(params[:id])
     if @agent.respond_to?(:handle_details_post)
@@ -285,21 +273,6 @@ def initialize_presenter
 
   private
 
-  def show_only_enabled_agents?
-    !!cookies[:active_workflow_view_only_enabled_agents]
-  end
-
-  def set_only_enabled_agents_as_viewable
-    cookies[:active_workflow_view_only_enabled_agents] = {
-      value: 'true',
-      expires: 1.year.from_now
-    }
-  end
-
-  def mark_all_agents_viewable
-    cookies.delete(:active_workflow_view_only_enabled_agents)
-  end
-
   def set_workflow
     return unless params[:workflow_id]
 

app/helpers/agent_helper.rb

@@ -6,14 +6,6 @@ def agent_show_view(agent)
     end
   end
 
-  def toggle_disabled_text
-    if cookies[:active_workflow_view_only_enabled_agents]
-      ' Show Disabled Agents'
-    else
-      ' Hide Disabled Agents'
-    end
-  end
-
   def workflow_links(agent)
     agent.workflows.map { |workflow|
       link_to(workflow.name, workflow, class: 'badge', style: style_colors(workflow))

app/views/agents/_buttons.html.erb

@@ -1,4 +1,3 @@
 <div class="d-flex justify-content-end">
   <%= link_to icon_tag('fa-plus') + ' New Agent', new_agent_path, class: "btn btn-primary btn-sm" %>
-  <%= link_to icon_tag('fa-adjust') + toggle_disabled_text, toggle_visibility_agents_path, method: :put, class: "btn btn-primary btn-sm" %>
 </div>

spec/controllers/agents_controller_spec.rb

@@ -16,14 +16,6 @@ def valid_attributes(options = {})
       get :index
       expect(assigns(:agents).all? { |i| expect(i.user).to eq(users(:bob)) }).to be_truthy
     end
-
-    it 'should not show disabled agents if the cookie is set' do
-      @request.cookies['active_workflow_view_only_enabled_agents'] = 'true'
-
-      sign_in users(:bob)
-      get :index
-      expect(assigns(:agents).map(&:disabled).uniq).to eq([false])
-    end
   end
 
   describe 'GET table' do
@@ -86,21 +78,6 @@ def valid_attributes(options = {})
     end
   end
 
-  describe 'PUT toggle_visibility' do
-    it 'should set the cookie' do
-      sign_in users(:jane)
-      put :toggle_visibility
-      expect(response.cookies['active_workflow_view_only_enabled_agents']).to eq('true')
-    end
-
-    it 'should delete the cookie' do
-      @request.cookies['active_workflow_view_only_enabled_agents'] = 'true'
-      sign_in users(:jane)
-      put :toggle_visibility
-      expect(response.cookies['active_workflow_view_only_enabled_agents']).to be_nil
-    end
-  end
-
   describe 'GET show' do
     it 'only shows Agents for the current user' do
       sign_in users(:bob)