Add additional dependancy for portfolio association to increase gap between role constraint creation

brightsparc · brightsparc · commit ded8eed269ea · 2021-04-30T12:40:40.000+10:00
diff --git a/infra/service_catalog.py b/infra/service_catalog.py
@@ -99,6 +99,7 @@ def __init__(
             principal_arn=execution_role_arn.value_as_string,
             principal_type="IAM",
         )
+        portfolio_association.add_depends_on(product)
 
         # Ensure we run the LaunchRoleConstrait last as there are timing issues on product/portfolio being created
         role_constraint = aws_servicecatalog.CfnLaunchRoleConstraint(

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ def __init__(`
`99`	`99`	`principal_arn=execution_role_arn.value_as_string,`
`100`	`100`	`principal_type="IAM",`
`101`	`101`	`)`
	`102`	`+ portfolio_association.add_depends_on(product)`
`102`	`103`
`103`	`104`	`# Ensure we run the LaunchRoleConstrait last as there are timing issues on product/portfolio being created`
`104`	`105`	`role_constraint = aws_servicecatalog.CfnLaunchRoleConstraint(`