Skip to content

Commit 2a6ae65

Browse files
fix(core): security group description tweaks (#438)
* Updating Security Group name deciding logic * Updating SG Description update version * Updating initial installerVersion number return if not found
1 parent 5de154e commit 2a6ae65

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/core/runtime/src/enable-trusted-access-for-services-step.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,5 +90,5 @@ export const handler = async (input: EnableTrustedAccessForServicesInput) => {
9090
// Finding the first entry of the parameter version
9191
const installerVersion = parameterHistoryList.find(p => p.Version === 1);
9292
const installerVersionValue = JSON.parse(installerVersion!.Value!);
93-
return !installerVersionValue.AcceleratorVersion ? '<1.2.1' : installerVersionValue.AcceleratorVersion;
93+
return !installerVersionValue.AcceleratorVersion ? '<1.2.2' : installerVersionValue.AcceleratorVersion;
9494
};

src/deployments/cdk/src/common/security-group.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,16 @@ export class SecurityGroup extends cdk.Construct {
6767

6868
const cleanVersion = sv.clean(installerVersion, { loose: true });
6969
let isUpdateDescription = false;
70+
const newSgDescriptionVersion = '1.2.2';
7071
if (cleanVersion) {
7172
// Checking only "major, minor, patch" versions. Ignoring characters appended to release tag
7273
if (sv.coerce(installerVersion)) {
73-
isUpdateDescription = sv.gte(sv.coerce(installerVersion)?.raw!, '1.2.1');
74+
isUpdateDescription = sv.gte(sv.coerce(installerVersion)?.raw!, newSgDescriptionVersion);
7475
} else {
75-
isUpdateDescription = sv.gte(installerVersion, '1.2.1');
76+
isUpdateDescription = sv.gte(installerVersion, newSgDescriptionVersion);
7677
}
7778
} else {
78-
isUpdateDescription = sv.satisfies('1.2.1', installerVersion);
79+
isUpdateDescription = sv.satisfies(newSgDescriptionVersion, installerVersion);
7980
}
8081

8182
// const securityGroups = vpcConfig['security-groups'];

0 commit comments

Comments
 (0)