fix: ECR Endpoints Not Functional #809 (#810)

* add logic for endpoints with . in name

* add logic for endpoints with . in name

* eslint fix

* prettier fix

Author: rjjaegeraws

src/deployments/cdk/src/common/interface-endpoints.ts

@@ -94,9 +94,10 @@ export class InterfaceEndpoint extends cdk.Construct {
 
     this._hostedZone.addDependsOn(endpoint);
 
+    const recordSetName = recordSetNameForRegionAndEndpointName(vpcRegion, serviceName);
     const recordSet = new route53.CfnRecordSet(this, 'RecordSet', {
       type: 'A',
-      name: hostedZoneName,
+      name: recordSetName,
       hostedZoneId: this._hostedZone.ref,
       aliasTarget: aliasTargetForServiceNameAndEndpoint(serviceName, endpoint),
     });
@@ -121,13 +122,18 @@ function interfaceVpcEndpointForRegionAndEndpointName(region: string, name: stri
   if (name === 'notebook') {
     return `aws.sagemaker.${region}.${name}`;
   }
+
   return `com.amazonaws.${region}.${name}`;
 }
 
 function zoneNameForRegionAndEndpointName(region: string, name: string) {
   if (name === 'notebook') {
     return `notebook.${region}.sagemaker.aws.`;
   }
+  if (name.indexOf('.') > 0) {
+    const tmp = name.split('.').reverse().join('.');
+    return `${tmp}.${region}.amazonaws.com.`;
+  }
   return `${name}.${region}.amazonaws.com.`;
 }
 
@@ -139,3 +145,13 @@ function getZoneAliasTargetIndex(name: string): number {
   }
   return 0;
 }
+
+function recordSetNameForRegionAndEndpointName(region: string, name: string) {
+  const hostedZoneName = zoneNameForRegionAndEndpointName(region, name);
+
+  if (name === 'ecr.dkr') {
+    return `*.${hostedZoneName}`;
+  }
+
+  return hostedZoneName;
+}