Skip to content

Commit 1f0a19b

Browse files
author
Ryan Lymburner
committed
Update comments
1 parent 9d6013b commit 1f0a19b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/gateway/model_build_targetgroup.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,9 @@ func (t *svcExportTargetGroupModelBuildTask) buildTargetGroupForExportedPort(ctx
164164
noSvcFoundAndDeleting := false
165165
if err := t.client.Get(ctx, k8s.NamespacedName(t.serviceExport), svc); err != nil {
166166
if apierrors.IsNotFound(err) && !t.serviceExport.DeletionTimestamp.IsZero() {
167-
// if we're deleting, it's OK if the service isn't there
167+
// If we're deleting, it's OK if the service isn't there
168168
noSvcFoundAndDeleting = true
169-
} else { // either it's some other error or we aren't deleting
169+
} else { // Either it's some other error or we aren't deleting
170170
return nil, fmt.Errorf("failed to find corresponding k8sService %s, error :%w ",
171171
k8s.NamespacedName(t.serviceExport), err)
172172
}
@@ -245,7 +245,7 @@ func (t *svcExportTargetGroupModelBuildTask) buildTargetsForPort(ctx context.Con
245245
targetsBuilder := NewTargetsBuilder(t.log, t.client, t.stack)
246246

247247
// We need to create a modified ServiceExport with the port annotation set to the specific port
248-
// This is a bit of a hack, but it allows us to reuse the existing BuildForServiceExport method
248+
// This allows us to reuse the existing BuildForServiceExport method
249249
modifiedServiceExport := t.serviceExport.DeepCopy()
250250
if modifiedServiceExport.Annotations == nil {
251251
modifiedServiceExport.Annotations = make(map[string]string)
@@ -264,9 +264,9 @@ func (t *svcExportTargetGroupModelBuildTask) buildTargetGroup(ctx context.Contex
264264
noSvcFoundAndDeleting := false
265265
if err := t.client.Get(ctx, k8s.NamespacedName(t.serviceExport), svc); err != nil {
266266
if apierrors.IsNotFound(err) && !t.serviceExport.DeletionTimestamp.IsZero() {
267-
// if we're deleting, it's OK if the service isn't there
267+
// If we're deleting, it's OK if the service isn't there
268268
noSvcFoundAndDeleting = true
269-
} else { // either it's some other error or we aren't deleting
269+
} else { // Either it's some other error or we aren't deleting
270270
return nil, fmt.Errorf("failed to find corresponding k8sService %s, error :%w ",
271271
k8s.NamespacedName(t.serviceExport), err)
272272
}
@@ -275,7 +275,7 @@ func (t *svcExportTargetGroupModelBuildTask) buildTargetGroup(ctx context.Contex
275275
var ipAddressType string
276276
var err error
277277
if noSvcFoundAndDeleting {
278-
ipAddressType = "IPV4" // just pick a default
278+
ipAddressType = "IPV4" // Pick a default
279279
} else {
280280
ipAddressType, err = buildTargetGroupIpAddressType(svc)
281281
if err != nil {

0 commit comments

Comments
 (0)