Fix panic on AccessLogPolicy targetRef namespace mismatch (#739)

j-vizcaino · Ryan Lymburner · web-flow · commit 4a816e5de775 · 2025-05-24T01:28:09.000Z
Fixes #626 Co-authored-by: Ryan Lymburner <137918933+rlymbur@users.noreply.github.com>
diff --git a/pkg/controllers/accesslogpolicy_controller.go b/pkg/controllers/accesslogpolicy_controller.go
@@ -182,7 +182,7 @@ func (r *accessLogPolicyReconciler) reconcileUpsert(ctx context.Context, alp *an
 	targetRefNamespace := k8s.NamespaceOrDefault(alp.Spec.TargetRef.Namespace)
 	if targetRefNamespace != alp.Namespace {
 		message := fmt.Sprintf("The targetRef's namespace, \"%s\", does not match the Access Log Policy's"+
-			" namespace, \"%s\"", string(*alp.Spec.TargetRef.Namespace), alp.Namespace)
+			" namespace, \"%s\"", targetRefNamespace, alp.Namespace)
 		r.eventRecorder.Event(alp, corev1.EventTypeWarning, k8s.FailedReconcileEvent, message)
 		return r.updateAccessLogPolicyStatus(ctx, alp, gwv1alpha2.PolicyReasonInvalid, message)
 	}

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ func (r accessLogPolicyReconciler) reconcileUpsert(ctx context.Context, alp an`
`182`	`182`	`targetRefNamespace := k8s.NamespaceOrDefault(alp.Spec.TargetRef.Namespace)`
`183`	`183`	`if targetRefNamespace != alp.Namespace {`
`184`	`184`	`message := fmt.Sprintf("The targetRef's namespace, \"%s\", does not match the Access Log Policy's"+`
`185`		`- " namespace, \"%s\"", string(*alp.Spec.TargetRef.Namespace), alp.Namespace)`
	`185`	`+ " namespace, \"%s\"", targetRefNamespace, alp.Namespace)`
`186`	`186`	`r.eventRecorder.Event(alp, corev1.EventTypeWarning, k8s.FailedReconcileEvent, message)`
`187`	`187`	`return r.updateAccessLogPolicyStatus(ctx, alp, gwv1alpha2.PolicyReasonInvalid, message)`
`188`	`188`	`}`