fix unit test assertion to be deterministic

VikramBedi · VikramBedi · commit c2d832db186a · 2025-12-05T15:26:55.000Z
diff --git a/pkg/gateway/model_build_lattice_service_test.go b/pkg/gateway/model_build_lattice_service_test.go
@@ -2071,7 +2071,12 @@ func Test_LatticeServiceModelBuild_FilterRejectedParentRefsForServiceNetworkAsso
 			svc, err := task.buildLatticeService(ctx)
 			assert.NoError(t, err, tt.description)
 			assert.NotNil(t, svc, tt.description)
-			assert.Equal(t, tt.expectedServiceNetworkNames, svc.Spec.ServiceNetworkNames, tt.description)
+
+			expectedNetworkNames := append([]string{}, tt.expectedServiceNetworkNames...)
+			actualNetworkNames := append([]string{}, svc.Spec.ServiceNetworkNames...)
+			sort.Strings(expectedNetworkNames)
+			sort.Strings(actualNetworkNames)
+			assert.Equal(t, expectedNetworkNames, actualNetworkNames, tt.description)
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -2071,7 +2071,12 @@ func Test_LatticeServiceModelBuild_FilterRejectedParentRefsForServiceNetworkAsso`
`2071`	`2071`	`svc, err := task.buildLatticeService(ctx)`
`2072`	`2072`	`assert.NoError(t, err, tt.description)`
`2073`	`2073`	`assert.NotNil(t, svc, tt.description)`
`2074`		`- assert.Equal(t, tt.expectedServiceNetworkNames, svc.Spec.ServiceNetworkNames, tt.description)`
	`2074`	`+`
	`2075`	`+ expectedNetworkNames := append([]string{}, tt.expectedServiceNetworkNames...)`
	`2076`	`+ actualNetworkNames := append([]string{}, svc.Spec.ServiceNetworkNames...)`
	`2077`	`+ sort.Strings(expectedNetworkNames)`
	`2078`	`+ sort.Strings(actualNetworkNames)`
	`2079`	`+ assert.Equal(t, expectedNetworkNames, actualNetworkNames, tt.description)`
`2075`	`2080`	`})`
`2076`	`2081`	`}`
`2077`	`2082`	`}`