replace push_back() vs emplace_back() on extension (#785)

Author: aismann

extensions/GUI/CCControlExtension/CCControl.cpp

@@ -210,7 +210,7 @@ void Control::removeTargetWithActionForControlEvent(Ref* target, Handler action,
             // Remove the corresponding invocation object
             if (shouldBeRemoved)
             {
-                tobeRemovedInvocations.push_back(invocation);
+                tobeRemovedInvocations.emplace_back(invocation);
             }
         }
 

extensions/GUI/CCScrollView/CCScrollView.cpp

@@ -713,7 +713,7 @@ bool ScrollView::onTouchBegan(Touch* touch, Event* /*event*/)
 
     if (std::find(_touches.begin(), _touches.end(), touch) == _touches.end())
     {
-        _touches.push_back(touch);
+        _touches.emplace_back(touch);
     }
 
     if (_touches.size() == 1)

extensions/Live2D/Framework/src/CubismFramework.cpp

@@ -228,7 +228,7 @@ void* CubismFramework::Allocate(csmSizeType size, const csmChar* fileName, csmIn
 
     if (s_allocationList)
     {
-        s_allocationList->push_back(address);
+        s_allocationList->emplace_back(address);
     }
 
     return address;
@@ -242,7 +242,7 @@ void* CubismFramework::AllocateAligned(csmSizeType size, csmUint32 alignment, co
 
     if (s_allocationList)
     {
-        s_allocationList->push_back(address);
+        s_allocationList->emplace_back(address);
     }
 
     return address;

extensions/Particle3D/CCParticle3DRender.cpp

@@ -314,7 +314,7 @@ void Particle3DModelRender::render(Renderer* renderer, const Mat4& transform, Pa
             }
             mesh->setTexture(_texFile);
             mesh->retain();
-            _meshList.push_back(mesh);
+            _meshList.emplace_back(mesh);
         }
         if (!_meshList.empty())
         {

extensions/Particle3D/CCParticleSystem3D.cpp

@@ -120,7 +120,7 @@ void ParticleSystem3D::addAffector(Particle3DAffector* affector)
     {
         affector->_particleSystem = this;
         affector->retain();
-        _affectors.push_back(affector);
+        _affectors.emplace_back(affector);
     }
 }
 

extensions/Particle3D/CCParticleSystem3D.h

@@ -75,15 +75,15 @@ class AX_EX_DLL DataPool
         if (_locked.empty())
             return nullptr;
         T* p = _locked.front();
-        //_released.push_back(p);
+        //_released.emplace_back(p);
         //_locked.erase(_locked.begin());
         _released.splice(_released.end(), _locked, _locked.begin());
         return p;
     }
 
     void lockLatestData()
     {
-        _locked.push_back(*_releasedIter);
+        _locked.emplace_back(*_releasedIter);
         _releasedIter = _released.erase(_releasedIter);
         if (_releasedIter != _released.begin() && _releasedIter != _released.end())
         {
@@ -135,7 +135,7 @@ class AX_EX_DLL DataPool
     const PoolList& getActiveDataList() const { return _released; };
     const PoolList& getUnActiveDataList() const { return _locked; };
 
-    void addData(T* data) { _locked.push_back(data); }
+    void addData(T* data) { _locked.emplace_back(data); }
 
     bool empty() const { return _released.empty(); };
 

extensions/Particle3D/PU/CCPUAffector.cpp

@@ -166,7 +166,7 @@ void PUAffector::addEmitterToExclude(std::string_view emitterName)
     auto iter = std::find(_excludedEmitters.begin(), _excludedEmitters.end(), emitterName);
     if (iter == _excludedEmitters.end())
     {
-        _excludedEmitters.push_back(std::string{emitterName});
+        _excludedEmitters.emplace_back(std::string{emitterName});
     }
 }
 

extensions/Particle3D/PU/CCPUBeamRender.cpp

@@ -149,7 +149,7 @@ void PUBeamRender::particleExpired(PUParticleSystem3D* /*particleSystem*/, PUPar
         PUParticle3DBeamVisualData* beamRendererVisualData =
             static_cast<PUParticle3DBeamVisualData*>(particle->visualData);
         beamRendererVisualData->setVisible(false, 0);  // PU 1.4
-        _visualData.push_back(beamRendererVisualData);
+        _visualData.emplace_back(beamRendererVisualData);
         particle->visualData = nullptr;
     }
 }
@@ -279,8 +279,8 @@ void PUBeamRender::prepare()
             visualData->half[numDev].setZero();
             visualData->destinationHalf[numDev].setZero();
         }
-        _allVisualData.push_back(visualData);  // Managed by this renderer
-        _visualData.push_back(visualData);     // Used to assign to a particle
+        _allVisualData.emplace_back(visualData);  // Managed by this renderer
+        _visualData.emplace_back(visualData);     // Used to assign to a particle
     }
 }
 

extensions/Particle3D/PU/CCPUDynamicAttribute.cpp

@@ -169,7 +169,7 @@ PUDynamicAttributeCurved::PUDynamicAttributeCurved(const PUDynamicAttributeCurve
     // Copy controlpoints
     for (const auto& controlPoint : dynamicAttributeCurved._controlPoints)
     {
-        _controlPoints.push_back(controlPoint);
+        _controlPoints.emplace_back(controlPoint);
     }
     processControlPoints();
 }
@@ -232,7 +232,7 @@ float PUDynamicAttributeCurved::getValue(float x)
 //-----------------------------------------------------------------------
 void PUDynamicAttributeCurved::addControlPoint(float x, float y)
 {
-    _controlPoints.push_back(Vec2(x, y));
+    _controlPoints.emplace_back(Vec2(x, y));
 }
 //-----------------------------------------------------------------------
 const PUDynamicAttributeCurved::ControlPointList& PUDynamicAttributeCurved::getControlPoints() const
@@ -314,7 +314,7 @@ void PUDynamicAttributeCurved::copyAttributesTo(PUDynamicAttribute* dynamicAttri
     for (it = _controlPoints.begin(); it != itEnd; ++it)
     {
         Vec2 controlPoint = *it;
-        dynAttr->_controlPoints.push_back(controlPoint);
+        dynAttr->_controlPoints.emplace_back(controlPoint);
     }
     dynAttr->processControlPoints();
 }

extensions/Particle3D/PU/CCPUMaterialManager.cpp

@@ -113,7 +113,7 @@ void PUMaterialCache::addMaterial(PUMaterial* material)
     }
 
     material->retain();
-    _materialMap.push_back(material);
+    _materialMap.emplace_back(material);
 }
 
 #if (AX_TARGET_PLATFORM == AX_PLATFORM_IOS || AX_TARGET_PLATFORM == AX_PLATFORM_MAC)