Skip to content

UpsertConfig metadataTTL property crashing after creation #191

@jleber

Description

@jleber

Hey @azaurus1, I hope you're doing well!

First, I want to thank you and congratulate you on the fantastic job with the Terraform Pinot integration.

I noticed that when we use the RealTime Table with the upsert configuration, the provider can create the resource successfully; however, it crashes when trying to read it, such as during subsequent Terraform plans after the initial creation with terraform apply. Here’s an example:

│ Error: Failed to get table
│ 
│   with module.metering-pinot-table["pipesign"].pinot_table.metering,
│   on ../../modules/pinot/table/main.tf line 1, in resource "pinot_table" "metering":
│    1: resource "pinot_table" "metering" {
│ 
│ client: could not unmarshal response JSON: json: cannot unmarshal number
│ 0.0 into Go struct field UpsertConfig.REALTIME.upsertConfig.metadataTTL of
│ type int64

Please note that we are using the Startree Pinot service, though I'm not sure if that makes any difference.

In these two pull requests (PR 1, PR 2) I proposed changing the data type to float64, similar to the DeletedKeysTTL property, which appears to be in the same situation but is already set as float64.

WDYT? Is it worth making this change?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions