diff --git a/exercises/MaxSubArraySum/Complete/MaxSubArraySumComplete.php b/exercises/MaxSubArraySum/Complete/MaxSubArraySumComplete.php index 9ca3b0b..892ec18 100644 --- a/exercises/MaxSubArraySum/Complete/MaxSubArraySumComplete.php +++ b/exercises/MaxSubArraySum/Complete/MaxSubArraySumComplete.php @@ -32,28 +32,4 @@ public static function max1(array $input, int $n): int return $max; } - - /** @param int[] $input */ - public static function max2(array $input, int $n): int - { - $length = count($input); - if ($length < $n) { - return 0; - } - $maxSum = 0; - $tempSum = 0; - - for ($i = 0; $i < $n; ++$i) { - $maxSum += $input[$i]; - } - - $tempSum = $maxSum; - - for ($i = $n; $i < $length; ++$i) { - $tempSum = ($tempSum - $input[$i - $n] + $input[$i]); - $maxSum = max($maxSum, $tempSum); - } - - return $maxSum; - } } diff --git a/exercises/MaxSubArraySum/MaxSubArraySum.php b/exercises/MaxSubArraySum/MaxSubArraySum.php index 3c9f82d..c6c77b6 100644 --- a/exercises/MaxSubArraySum/MaxSubArraySum.php +++ b/exercises/MaxSubArraySum/MaxSubArraySum.php @@ -9,7 +9,7 @@ * * @method static int max(int[] $input, int $n) * @example MaxSubArraySum::max([1, 2, 3], 2)) === 5 - * @example MaxSubArraySum::max([2, 6, 9, 2, 1, 8, 5, 6, 3], 3)) === 19 + * @example MaxSubArraySum::max([2, 6, 9, 2, 1, 8, 5, 6, 3], 3)) === 23 */ final class MaxSubArraySum { diff --git a/tests/MaxSubArraySum/Complete/MaxSubArrayCompleteTest.php b/tests/MaxSubArraySum/Complete/MaxSubArrayCompleteTest.php index 0bb0f35..1529e9c 100644 --- a/tests/MaxSubArraySum/Complete/MaxSubArrayCompleteTest.php +++ b/tests/MaxSubArraySum/Complete/MaxSubArrayCompleteTest.php @@ -16,10 +16,6 @@ public function testHasMethods(): void method_exists(MaxSubArraySumComplete::class, 'max1'), 'Class does not have static method max1' ); - self::assertTrue( - method_exists(MaxSubArraySumComplete::class, 'max2'), - 'Class does not have static method max2' - ); } public function testMax1(): void @@ -31,14 +27,4 @@ public function testMax1(): void ); self::assertSame(0, MaxSubArraySumComplete::max1([1, 2, 3], 5)); } - - public function testMax2(): void - { - self::assertSame(5, MaxSubArraySumComplete::max2([1, 2, 3], 2)); - self::assertSame( - 19, - MaxSubArraySumComplete::max2([2, 6, 9, 2, 1, 8, 5, 6, 3], 3) - ); - self::assertSame(0, MaxSubArraySumComplete::max1([1, 2, 3], 5)); - } }