Skip to content

Commit c63086c

Browse files
author
Bartosz Litwiniuk
committed
Remove try-catch
1 parent b4ebcbf commit c63086c

File tree

1 file changed

+26
-29
lines changed

1 file changed

+26
-29
lines changed

backtrace-library/src/androidTest/java/backtraceio/library/breadcrumbs/BacktraceBreadcrumbsTest.java

Lines changed: 26 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,15 @@
1010
import androidx.test.platform.app.InstrumentationRegistry;
1111
import androidx.test.ext.junit.runners.AndroidJUnit4;
1212

13+
import org.json.JSONException;
1314
import org.json.JSONObject;
1415
import org.junit.After;
1516
import org.junit.Before;
1617
import org.junit.Test;
1718
import org.junit.runner.RunWith;
1819

1920
import java.io.File;
21+
import java.io.IOException;
2022
import java.util.HashMap;
2123
import java.util.LinkedHashMap;
2224
import java.util.List;
@@ -390,42 +392,37 @@ public void testQueueFileShouldNotRolloverCustomMax() {
390392
}
391393

392394
@Test
393-
public void testQueueFileRolloverCustomMax() {
395+
public void testQueueFileRolloverCustomMax() throws IOException, JSONException {
394396
int numIterations = 100;
395397
// Cleanup after default BacktraceBreadcrumbs constructor
396398
// Because we want to create our own instance with custom parameters
397399
cleanUp();
398400

399-
try {
400-
backtraceBreadcrumbs = new BacktraceBreadcrumbs(this.absolutePath);
401-
backtraceBreadcrumbs.enableBreadcrumbs(context, 6400);
402-
// Account for mandatory configuration breadcrumb
403-
backtraceBreadcrumbs.setCurrentBreadcrumbId(1);
404-
405-
for (int i = 0; i < numIterations; i++) {
406-
final long threadId = Thread.currentThread().getId();
407-
Map<String, Object> attributes = new HashMap<String, Object>() {{
408-
put("From Thread", threadId);
409-
}};
410-
backtraceBreadcrumbs.addBreadcrumb("I am a breadcrumb", attributes);
411-
}
412-
413-
List<String> breadcrumbLogFileData = BreadcrumbsReader.readBreadcrumbLogFile(this.absolutePath);
401+
backtraceBreadcrumbs = new BacktraceBreadcrumbs(this.absolutePath);
402+
backtraceBreadcrumbs.enableBreadcrumbs(context, 6400);
403+
// Account for mandatory configuration breadcrumb
404+
backtraceBreadcrumbs.setCurrentBreadcrumbId(1);
414405

415-
// We should have rolled over the configuration breadcrumb, consider all breadcrumbs here
416-
for (int i = 0; i < breadcrumbLogFileData.size(); i++) {
417-
JSONObject parsedBreadcrumb = new JSONObject(breadcrumbLogFileData.get(i));
418-
assertEquals("I am a breadcrumb", parsedBreadcrumb.get("message"));
419-
assertNotNull(parsedBreadcrumb.getJSONObject("attributes").get("From Thread"));
420-
assertEquals("manual", parsedBreadcrumb.get("type"));
421-
assertEquals("info", parsedBreadcrumb.get("level"));
422-
// Timestamp should be convertible to a long
423-
assertTrue(parsedBreadcrumb.get("timestamp") instanceof Long);
424-
assertTrue(((int) parsedBreadcrumb.get("id")) > 45);
425-
}
406+
for (int i = 0; i < numIterations; i++) {
407+
final long threadId = Thread.currentThread().getId();
408+
Map<String, Object> attributes = new HashMap<String, Object>() {{
409+
put("From Thread", threadId);
410+
}};
411+
backtraceBreadcrumbs.addBreadcrumb("I am a breadcrumb", attributes);
412+
}
426413

427-
} catch (Exception ex) {
428-
fail(ex.getMessage());
414+
List<String> breadcrumbLogFileData = BreadcrumbsReader.readBreadcrumbLogFile(this.absolutePath);
415+
416+
// We should have rolled over the configuration breadcrumb, consider all breadcrumbs here
417+
for (int i = 0; i < breadcrumbLogFileData.size(); i++) {
418+
JSONObject parsedBreadcrumb = new JSONObject(breadcrumbLogFileData.get(i));
419+
assertEquals("I am a breadcrumb", parsedBreadcrumb.get("message"));
420+
assertNotNull(parsedBreadcrumb.getJSONObject("attributes").get("From Thread"));
421+
assertEquals("manual", parsedBreadcrumb.get("type"));
422+
assertEquals("info", parsedBreadcrumb.get("level"));
423+
// Timestamp should be convertible to a long
424+
assertTrue(parsedBreadcrumb.get("timestamp") instanceof Long);
425+
assertTrue(((int) parsedBreadcrumb.get("id")) > 45);
429426
}
430427
}
431428

0 commit comments

Comments
 (0)