Handle corrupt or empty database records (#78)

* Handle corrupt or empty database records

In cases where a crash record file is corrupted or empty,
BacktraceDatabaseRecord.readFromFile will return null

Adds handling for this case by treating it as an invalid record

* Add unit test, fix checking null record

Co-authored-by: Selali Adobor <selali.adobor@gmail.com>
Co-authored-by: Bartosz Litwiniuk <>

Author: BartoszLitwiniuk

backtrace-library/src/androidTest/java/backtraceio/library/database/BacktraceDatabaseTest.java

@@ -14,10 +14,12 @@
 import org.junit.runner.RunWith;
 
 import java.io.File;
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.UUID;
 
 import backtraceio.library.BacktraceClient;
 import backtraceio.library.BacktraceCredentials;
@@ -196,4 +198,20 @@ public void recordLimit() {
         assertEquals(report2.message, database.get().iterator().next().getBacktraceData(context).report.message);
     }
 
+    @Test
+    public void addEmptyFileAndStartDatabase() throws IOException {
+        // GIVEN
+        File file = new File(
+                new File(this.dbPath, String.format("%s-record.json", UUID.randomUUID())).getAbsolutePath()
+        );
+        file.createNewFile();
+
+        // WHEN
+        BacktraceDatabase database = new BacktraceDatabase(this.context, this.dbPath);
+        database.start();
+
+        // THEN
+        assertEquals(database.count(), 0);
+    }
+
 }

backtrace-library/src/main/java/backtraceio/library/BacktraceDatabase.java

@@ -415,6 +415,10 @@ private void loadReports() {
 
         for (File file : files) {
             BacktraceDatabaseRecord record = BacktraceDatabaseRecord.readFromFile(file);
+            if (record == null) {
+                continue;
+            }
+
             if (!record.valid()) {
                 record.delete();
                 continue;

backtrace-library/src/main/java/backtraceio/library/models/database/BacktraceDatabaseRecord.java

@@ -74,7 +74,6 @@ public class BacktraceDatabaseRecord {
         this._path = "";
         this.recordPath = String.format("%s-record.json", this.id);
         this.diagnosticDataPath = String.format("%s-attachment", this.id);
-        this.recordPath = String.format("%s-record.json", this.id);
     }
 
     public BacktraceDatabaseRecord(BacktraceData data, String path) {