Remove session finalizer (nhibernate#2811)

Author: bahusoid

src/NHibernate/Impl/SessionImpl.cs

@@ -1483,14 +1483,6 @@ public void Reconnect(DbConnection conn)
 		private string fetchProfile;
 		private IDisposable _context;
 
-		/// <summary>
-		/// Finalizer that ensures the object is correctly disposed of.
-		/// </summary>
-		~SessionImpl()
-		{
-			Dispose(false);
-		}
-
 		/// <summary>
 		/// Perform a soft (distributed transaction aware) close of the session
 		/// </summary>
@@ -1517,15 +1509,12 @@ public void Dispose()
 			_context?.Dispose();
 		}
 
+		//TODO: Get rid of isDisposing parameter. Finalizer is removed as not needed, so isDisposing  is always true
 		/// <summary>
 		/// Takes care of freeing the managed and unmanaged resources that
 		/// this class is responsible for.
 		/// </summary>
 		/// <param name="isDisposing">Indicates if this Session is being Disposed of or Finalized.</param>
-		/// <remarks>
-		/// If this Session is being Finalized (<c>isDisposing==false</c>) then make sure not
-		/// to call any methods that could potentially bring this Session back to life.
-		/// </remarks>
 		private void Dispose(bool isDisposing)
 		{
 			using (BeginContext())
@@ -1546,8 +1535,6 @@ private void Dispose(bool isDisposing)
 					{
 						Close();
 					}
-					// nothing for Finalizer to do - so tell the GC to ignore it
-					GC.SuppressFinalize(this);
 				}
 
 				// free unmanaged resources here

src/NHibernate/Impl/StatelessSessionImpl.cs

@@ -759,14 +759,6 @@ public IQueryOver<T, T> QueryOver<T>(Expression<Func<T>> alias) where T : class
 		private bool _isAlreadyDisposed;
 		private IDisposable _context;
 
-		/// <summary>
-		/// Finalizer that ensures the object is correctly disposed of.
-		/// </summary>
-		~StatelessSessionImpl()
-		{
-			Dispose(false);
-		}
-
 		///<summary>
 		///Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources.
 		///</summary>
@@ -793,6 +785,7 @@ public void Dispose()
 			}
 		}
 
+		//TODO: Get rid of isDisposing parameter. Finalizer is removed as not needed, so isDisposing  is always true
 		protected void Dispose(bool isDisposing)
 		{
 			using (BeginContext())
@@ -811,9 +804,6 @@ protected void Dispose(bool isDisposing)
 					{
 						Close();
 					}
-
-					// nothing for Finalizer to do - so tell the GC to ignore it
-					GC.SuppressFinalize(this);
 				}
 
 				// free unmanaged resources here