Siemens TCP/IP Ethernet cannot write bug fixed

Author: bambooww

core/src/main/java/org/iottree/core/DevDriver.java

@@ -504,9 +504,6 @@ synchronized final boolean RT_start(StringBuilder failedr) throws Exception
 			rtTh = new Thread(runner, "iottree-devdriver-" + this.getBelongToCh().getName() + " " + this.getName());
 			rtTh.start();
 		}
-
-		
-
 		return true;
 	}
 
@@ -672,7 +669,7 @@ synchronized final void RT_stop(boolean bforce)
 
 	public boolean RT_isRunning()
 	{
-		return rtTh != null;
+		return bRun;// rtTh != null; 
 	}
 
 	public State getDriverState()

core/src/main/java/org/iottree/core/UATag.java

@@ -1533,10 +1533,13 @@ public UAVal RT_setValRaw(Object v,Long updt,Long chgdt)
 		return this.RT_setValRaw(v,true,updt,chgdt);
 	}
 
-	private boolean RT_writeValDriver(Object v)
+	private boolean RT_writeValDriver(Object v,StringBuilder failedr)
 	{
 		if(this.isMidExpress())
+		{
+			failedr.append("mid express tag cannot be written") ;
 			return false;
+		}
 
 		StringBuilder sb = new StringBuilder() ;
 		DevAddr da = this.getDevAddr(sb);
@@ -1545,17 +1548,24 @@ private boolean RT_writeValDriver(Object v)
 
 		UACh ch = this.getBelongToCh() ;
 		if(ch==null)
+		{
+			failedr.append("no belong to ch found") ;
 			return false; //must has channel
+		}
 		UADev dev = this.getBelongToDev();
 		//if(dev==null)
 		//	return false;
-		
 		DevDriver dd = ch.getDriver() ;
 		if(dd==null)
+		{
+			failedr.append("no driver found") ;
 			return false;
-
+		}
 		if(!dd.RT_isRunning())
+		{
+			failedr.append("driver is not running") ;
 			return false;
+		}
 
 		ValTranser vtrans = this.getValTranserObj() ;
 		if(vtrans!=null)
@@ -1564,13 +1574,17 @@ private boolean RT_writeValDriver(Object v)
 			{
 				v = vtrans.inverseTransVal(v) ;
 				if(v==null)
+				{
+					failedr.append("inverseTransVal is null") ;
 					return false;
+				}
 				v = UAVal.transStr2ObjVal(this.getValTpRaw(),v.toString()) ;
 			}
 			catch(Exception ee)
 			{
 				//if(Log.isDebugging())
 				ee.printStackTrace();
+				failedr.append("RT_writeValDriver err:"+ee.getMessage()) ;
 				return false;
 			}
 		}
@@ -1637,9 +1651,9 @@ else if(ch.isConnBind())
 			}
 			else
 			{
-				boolean r = RT_writeValDriver(v);
-				if(!r && failedr!=null)
-					failedr.append("write to driver failed") ;
+				boolean r = RT_writeValDriver(v,failedr);
+				//if(!r && failedr!=null)
+				//	failedr.append("write to driver failed") ;
 				return r ;
 			}
 		}

driver-parent/driver-common/src/main/java/org/iottree/driver/s7/eth/S7Block.java

@@ -400,8 +400,6 @@ public boolean setWriteCmdAsyn(S7Addr addr, Object v)
 	{
 		S7MsgWrite mc = new S7MsgWrite().withParam(memTp, this.dbNum, addr,v);
 		mc.init(ppiDrv);
-
-		
 		synchronized(writeCmds)
 		{
 			writeCmds.addLast(mc);