m

Author: barakugav

.github/workflows/ci.yaml

@@ -22,6 +22,7 @@ jobs:
       matrix:
         # runner: [ubuntu-22.04, macos-latest]
         runner: [ubuntu-22.04]
+        # runner: [macos-latest]
     permissions:
       contents: read
       checks: write
@@ -148,13 +149,9 @@ jobs:
       - name: Build nano-gpt example
         run: cargo build
         working-directory: examples/nano-gpt
-        env:
-          EXECUTORCH_RS_LINK: 0
       - name: Build llama3 example
         run: cargo build
         working-directory: examples/llama3
-        env:
-          EXECUTORCH_RS_LINK: 0
 
   # check:
   #   runs-on: ${{ matrix.runner }}

examples/llama3/build.rs

@@ -4,7 +4,7 @@ fn main() {
         .expect("EXECUTORCH_RS_EXECUTORCH_LIB_DIR is not set, can't locate executorch static libs");
 
     println!("cargo::rustc-link-search=native={libs_dir}/kernels/portable/");
-    println!("cargo::rustc-link-lib=static=portable_kernels");
+    println!("cargo::rustc-link-lib=static:+whole-archive=portable_kernels");
 
     println!("cargo::rustc-link-search=native={libs_dir}/configurations/");
     println!("cargo::rustc-link-lib=static:+whole-archive=optimized_native_cpu_ops_lib");

examples/nano-gpt/build.rs

@@ -4,7 +4,7 @@ fn main() {
         .expect("EXECUTORCH_RS_EXECUTORCH_LIB_DIR is not set, can't locate executorch static libs");
 
     println!("cargo::rustc-link-search=native={libs_dir}/kernels/portable/");
-    println!("cargo::rustc-link-lib=static=portable_kernels");
+    println!("cargo::rustc-link-lib=static:+whole-archive=portable_kernels");
 
     println!("cargo::rustc-link-search=native={libs_dir}/configurations/");
     println!("cargo::rustc-link-lib=static:+whole-archive=optimized_native_cpu_ops_lib");