Skip to content

Commit cdb2b3e

Browse files
committed
Remove the false impresion that some bzl files are not public
The value of INTERNAL_VISIBILIY variable was changed to public. However, the name of the variable seems to imply that it is not public. Removing it makes that clear.
1 parent eeff234 commit cdb2b3e

File tree

4 files changed

+2
-15
lines changed

4 files changed

+2
-15
lines changed

cc/common/BUILD

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ bzl_library(
4141
deps = [
4242
":cc_helper_internal_bzl",
4343
":common",
44-
":visibility_bzl",
4544
"//cc:find_cc_toolchain_bzl",
4645
"//cc/private:paths_bzl",
4746
"//cc/private/rules_impl:objc_common",
@@ -80,17 +79,10 @@ bzl_library(
8079
visibility = ["//visibility:public"],
8180
deps = [
8281
":cc_helper_bzl",
83-
":visibility_bzl",
8482
"//cc:find_cc_toolchain_bzl",
8583
],
8684
)
8785

88-
bzl_library(
89-
name = "visibility_bzl",
90-
srcs = ["visibility.bzl"],
91-
visibility = ["//visibility:private"],
92-
)
93-
9486
filegroup(
9587
name = "srcs",
9688
srcs = glob([

cc/common/cc_debug_helper.bzl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@ load("//cc:action_names.bzl", "ACTION_NAMES")
1717
load("//cc:find_cc_toolchain.bzl", "CC_TOOLCHAIN_TYPE")
1818
load(":cc_common.bzl", "cc_common")
1919
load(":cc_helper.bzl", "linker_mode")
20-
load(":visibility.bzl", "INTERNAL_VISIBILITY")
2120

22-
visibility(INTERNAL_VISIBILITY)
21+
visibility("public")
2322

2423
def create_debug_packager_actions(
2524
ctx,

cc/common/cc_helper.bzl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@ load(
3030
_repository_exec_path = "repository_exec_path",
3131
)
3232
load(":cc_info.bzl", "CcInfo")
33-
load(":visibility.bzl", "INTERNAL_VISIBILITY")
3433

35-
visibility(INTERNAL_VISIBILITY)
34+
visibility("public")
3635

3736
# LINT.IfChange(linker_mode)
3837
linker_mode = struct(

cc/common/visibility.bzl

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)