Disable obsolete QA tools and introduce CS fixer in actions (#40)

* Disable obsolete QA tools and introduce CS fixer in actions

* Add CI specific run command for PHP-Cs-Fixer

Author: ttomdewit

.github/workflows/actions.yaml

@@ -17,14 +17,10 @@ jobs:
           - 7.3
           - 7.4
         suite:
-          - infection-ci
-          - phan
-          - php-cbf
-          - php-cs
+          - php-cs-fixer-ci
           - phplint
-          - phpstan
           - phpunit
-          - psalm
+          - infection-ci
 
     name: PHP ${{ matrix.php }} testing ${{ matrix.suite }}
     steps:

composer.json

@@ -67,6 +67,7 @@
         "psalm": "vendor/bin/psalm src",
         "phplint": "vendor/bin/phplint src",
         "php-cs-fixer": "vendor/bin/php-cs-fixer fix",
+        "php-cs-fixer-ci": "vendor/bin/php-cs-fixer fix --dry-run --stop-on-violation",
         "php-cbf": "vendor/bin/phpcbf src --standard=PSR1,PSR2,PSR12",
         "php-cs": "vendor/bin/phpcs src --standard=PSR1,PSR2,PSR12",
         "phan": "vendor/bin/phan --allow-polyfill-parser src",

src/Factories/ConverterFactory.php

@@ -39,6 +39,7 @@ public function build(
                 );
 
                 break;
+
             case 'PHP_CodeSniffer':
                 $converter = new PhpCodeSnifferConvertToSubset(
                     $validator,
@@ -47,6 +48,7 @@ public function build(
                 );
 
                 break;
+
             case 'PHPLint':
                 $converter = new PhpLintConvertToSubset(
                     $validator,
@@ -55,6 +57,7 @@ public function build(
                 );
 
                 break;
+
             case 'PHPStan':
                 $converter = new PHPStanConvertToSubset(
                     $validator,
@@ -63,6 +66,7 @@ public function build(
                 );
 
                 break;
+
             case 'Psalm':
                 $converter = new PsalmConvertToSubset(
                     $validator,
@@ -71,6 +75,7 @@ public function build(
                 );
 
                 break;
+
             case 'PHP-CS-Fixer':
                 $converter = new PHPCSFixerConvertToSubset(
                     $validator,

src/Factories/ValidatorFactory.php

@@ -28,22 +28,27 @@ public function build(
                 $validator = new PhanJsonValidator($json);
 
                 break;
+
             case 'PHP_CodeSniffer':
                 $validator = new PhpCodeSnifferJsonValidator($json);
 
                 break;
+
             case 'PHPLint':
                 $validator = new PhpLintJsonValidator($json);
 
                 break;
+
             case 'PHPStan':
                 $validator = new PHPStanJsonValidator($json);
 
                 break;
+
             case 'Psalm':
                 $validator = new PsalmJsonValidator($json);
 
                 break;
+
             case 'PHP-CS-Fixer':
                 $validator = new PHPCSFixerJsonValidator($json);
 

tests/Command/CommandTest.php

@@ -925,8 +925,7 @@ public function testItExitsWithZeroExitCodeWhenErrorsWereConvertedWhenFailOnConv
         string $converter,
         array $output,
         string $name
-    ): void
-    {
+    ): void {
         // Given
         $jsonFileName = __DIR__.'/..'.$jsonInput;
         $jsonInput = file_get_contents(__DIR__.'/..'.$jsonInput);
@@ -968,7 +967,7 @@ public function testItExitsWithZeroExitCodeWhenErrorsWereConvertedWhenFailOnConv
         $commandTester->execute(
             [
                 $converterImplementationOptionName => true,
-                $converterImplementationOptionFilePath => $jsonFileName
+                $converterImplementationOptionFilePath => $jsonFileName,
             ]
         );