flash messages not going away

[djpnewton]

In the latest Nancy the flash messages do not go away (in the next request/response) after they are rendered. It seems to be because the session is saved to the response cookie before the view is rendered (which pops the flash out of the session).

[djpnewton]

If you render your view like so:

    public static Response ViewRenderedInline(this NancyModule module, string viewName, dynamic model)
    {
        ViewLocationContext viewLocationContext = new ViewLocationContext()
        {
            Context = module.Context,
            ModuleName = module.GetType().Name,
            ModulePath = module.ModulePath
        };
        var rendered = module.ViewFactory.RenderView(viewName, model, viewLocationContext);
        using (var ms = new MemoryStream())
        {
            rendered.Contents.Invoke(ms);
            ms.Seek(0, SeekOrigin.Begin);
            using (TextReader reader = new StreamReader(ms))
            {
                return new TextResponse(reader.ReadToEnd(), "text/html");
            }
        };
    }

The flash messages will be removed from the session (as this now happens before the session is saved to the response) but its not ideal

[djpnewton]

I have confirmed that one should not modify the session from inside a view: http://stackoverflow.com/questions/36964736/nancy-request-pipeline-order

I have a workaround here djpnewton@2ace150

Basically the session is modified in a post-request action and the messages are then put in the viewbag