Skip to content

Commit 320a799

Browse files
committed
Use data-name instead of name on time widget's inputs
This is to avoid sending their values when form is submitted.
1 parent 7d27a91 commit 320a799

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/components/widgets.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export class TimePicker extends React.Component {
3333
}
3434

3535
handleChange = (e) => {
36-
let name = e.target.name;
36+
let name = e.target.dataset.name;
3737
let value = e.target.value;
3838

3939
if (isNaN(value))
@@ -52,7 +52,7 @@ export class TimePicker extends React.Component {
5252
if (e.keyCode !== 38 && e.keyCode !== 40)
5353
return;
5454

55-
let name = e.target.name;
55+
let name = e.target.dataset.name;
5656
let value = parseInt(e.target.value) || 0;
5757

5858
if (e.keyCode === 38) {
@@ -86,7 +86,7 @@ export class TimePicker extends React.Component {
8686

8787
handleBlur = (e) => {
8888
if ((parseInt(e.target.value) || 0) < 10) {
89-
this.setState({[e.target.name]: e.target.value.padStart(2, '0')});
89+
this.setState({[e.target.dataset.name]: e.target.value.padStart(2, '0')});
9090
}
9191
}
9292

@@ -114,11 +114,11 @@ export class TimePicker extends React.Component {
114114
</div>
115115

116116
<div className="rjf-time-picker-row rjf-time-picker-values">
117-
<div className="rjf-time-picker-col"><input type="text" name="hh" value={this.state.hh} onChange={this.handleChange} onBlur={this.handleBlur} onKeyDown={this.handleKeyDown} /></div>
117+
<div className="rjf-time-picker-col"><input type="text" data-name="hh" value={this.state.hh} onChange={this.handleChange} onBlur={this.handleBlur} onKeyDown={this.handleKeyDown} /></div>
118118
<div className="rjf-time-picker-col rjf-time-picker-col-sm">:</div>
119-
<div className="rjf-time-picker-col"><input type="text" name="mm" value={this.state.mm} onChange={this.handleChange} onBlur={this.handleBlur} onKeyDown={this.handleKeyDown} /></div>
119+
<div className="rjf-time-picker-col"><input type="text" data-name="mm" value={this.state.mm} onChange={this.handleChange} onBlur={this.handleBlur} onKeyDown={this.handleKeyDown} /></div>
120120
<div className="rjf-time-picker-col rjf-time-picker-col-sm">:</div>
121-
<div className="rjf-time-picker-col"><input type="text" name="ss" value={this.state.ss} onChange={this.handleChange} onBlur={this.handleBlur} onKeyDown={this.handleKeyDown} /></div>
121+
<div className="rjf-time-picker-col"><input type="text" data-name="ss" value={this.state.ss} onChange={this.handleChange} onBlur={this.handleBlur} onKeyDown={this.handleKeyDown} /></div>
122122
<div className="rjf-time-picker-col rjf-time-picker-col-sm"></div>
123123
<div className="rjf-time-picker-col">{this.state.ampm}</div>
124124
</div>

0 commit comments

Comments
 (0)