Merge pull request #5 from ksyuzi/bugfix/issue/1

Bugfix for issue #1

Author: bieli

src/codecs/item_codec.py

@@ -31,7 +31,7 @@ def decode(
     def encode(
         item: Item, split_kind_char: str = "|", split_data_item_char: str = "="
     ) -> str:
-        item_str = f"{item.kind}{split_kind_char}{item.name}"
+        item_str = f"{item.kind.value}{split_kind_char}{item.name}"
         if item.metric is not None:
             item_str += (
                 f"{split_data_item_char}{MetricDataItemCodec.encode(item.metric)}"

src/codecs/metric_data_item_codec.py

@@ -31,7 +31,7 @@ def encode(mdi: MetricDataItem, data_type_and_value_char: str = ":") -> str:
             value = str(value)
         elif mdi.data_type == MetricDataTypes.TEXT.value:
             value = str(value)
-        return f"{mdi.data_type}{data_type_and_value_char}{value}"
+        return f"{mdi.data_type.value}{data_type_and_value_char}{value}"
 
     @staticmethod
     def from_value(value: MetricValueType) -> MetricDataItem:

src/types/item_type.py

@@ -9,10 +9,3 @@ class ItemTypes(str, Enum):
     DEVICE_ID = "d"
     METRIC_ITEM = "m"
     HEALTH_CHECK = "h"
-
-
-@dataclass(frozen=True)
-class Item:
-    kind: ItemTypes
-    name: str
-    metric: Optional[MetricDataItem] = None

tests/codecs/test_iot_ext_codec.py

@@ -2,7 +2,8 @@
 from unittest import TestCase, skip
 
 from src.codecs.iot_ext_codec import IoTextCodec
-from src.types.item_type import Item, ItemTypes, MetricDataItem
+from src.types.item import Item
+from src.types.item_type import ItemTypes, MetricDataItem
 from src.types.metric_data import MetricDataTypes
 
 MSG_1_EXAMPLE = (
@@ -74,8 +75,6 @@
 
 
 class IoTextCodecTest(TestCase):
-    # TODO: verify where is a bug!?
-    @skip
     def test_decode(self):
         expected = MSG_1_EXAMPLE_AS_DATA_STRUCTS