diff --git a/.travis.yml b/.travis.yml index c0b1791..8e74530 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,9 @@ cache: - "$HOME/.yarn" - "./node_modules" before_install: +- composer self-update 1.10.26 +- nvm install 10 +- nvm use 10 - travis_retry yarn jobs: include: @@ -24,8 +27,16 @@ jobs: php: 7.3 script: - "./bin/lint.sh" + - stage: lint + php: 7.4 + script: + - "./bin/lint.sh" + - stage: lint + php: 8.0 + script: + - "./bin/lint.sh" - stage: deploy - php: 7.2 + php: 7.4 script: - "./bin/build.sh" if: branch = master diff --git a/author.php b/author.php index 0a94aed..10c92a6 100644 --- a/author.php +++ b/author.php @@ -20,7 +20,7 @@

- Photo of <?php echo esc_html( $author_name ); ?> + Photo of <?php echo esc_attr( $author_name ); ?>
diff --git a/bin/lint.sh b/bin/lint.sh index 2725b2f..7c49563 100755 --- a/bin/lint.sh +++ b/bin/lint.sh @@ -1,6 +1,7 @@ #!/usr/bin/env sh + composer global require \ - dealerdirect/phpcodesniffer-composer-installer:0.5.0 \ - wp-coding-standards/wpcs:1.2.1 \ - automattic/vipwpcs:0.4.0 \ + dealerdirect/phpcodesniffer-composer-installer:0.7.2 \ + wp-coding-standards/wpcs:2.3.0 \ + automattic/vipwpcs:2.3.0 \ && yarn lint diff --git a/block-languages/benenson-blocks.pot b/block-languages/benenson-blocks.pot index f540a1c..c0f76b1 100644 --- a/block-languages/benenson-blocks.pot +++ b/block-languages/benenson-blocks.pot @@ -37,7 +37,7 @@ msgid "Centre align the action block." msgstr "" #: src/scripts/blocks/action/DisplayComponent.js:80 -#: src/scripts/blocks/image/DisplayComponent.js:239 +#: src/scripts/blocks/image/DisplayComponent.js:237 #: src/scripts/blocks/post-list/components/editable/GridItem.js:57 #: src/scripts/blocks/post-list/components/editable/PostItem.js:96 #: src/scripts/blocks/post-list/components/editable/SplitGridItem.js:65 @@ -174,14 +174,14 @@ msgstr "" # text alignment. for RTL languages, localise as 'Right' #: src/scripts/blocks/blockquote/index.js:227 #: src/scripts/blocks/header/DisplayComponent.js:77 -#: src/scripts/blocks/image/DisplayComponent.js:201 +#: src/scripts/blocks/image/DisplayComponent.js:199 #: src/scripts/blocks/link/DisplayComponent.js:41 #: src/scripts/blocks/slider/DisplayComponent.js:37 msgid "Left" msgstr "" #: src/scripts/blocks/blockquote/index.js:228 -#: src/scripts/blocks/image/DisplayComponent.js:197 +#: src/scripts/blocks/image/DisplayComponent.js:195 #: src/scripts/blocks/section/index.js:53 #: src/scripts/blocks/tweet/index.js:26 msgid "Default" @@ -190,7 +190,7 @@ msgstr "" # text alignment. for RTL languages, localise as 'Left' #: src/scripts/blocks/blockquote/index.js:233 #: src/scripts/blocks/header/DisplayComponent.js:84 -#: src/scripts/blocks/image/DisplayComponent.js:208 +#: src/scripts/blocks/image/DisplayComponent.js:206 #: src/scripts/blocks/link/DisplayComponent.js:47 #: src/scripts/blocks/slider/DisplayComponent.js:44 msgid "Right" @@ -199,20 +199,20 @@ msgstr "" #: src/scripts/blocks/blockquote/index.js:289 #: src/scripts/blocks/header/DisplayComponent.js:115 #: src/scripts/blocks/links-with-icons/InnerDisplayComponent.js:223 -#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:95 +#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:94 #: src/scripts/blocks/section/DisplayComponent.js:61 msgid "Small" msgstr "" #: src/scripts/blocks/blockquote/index.js:292 #: src/scripts/blocks/links-with-icons/InnerDisplayComponent.js:226 -#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:98 +#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:97 msgid "Medium" msgstr "" #: src/scripts/blocks/blockquote/index.js:295 #: src/scripts/blocks/links-with-icons/InnerDisplayComponent.js:229 -#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:101 +#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:100 msgid "Large" msgstr "" @@ -232,7 +232,7 @@ msgstr "" #: src/scripts/blocks/blockquote/index.js:323 #: src/scripts/blocks/header/DisplayComponent.js:123 -#: src/scripts/blocks/image/DisplayComponent.js:220 +#: src/scripts/blocks/image/DisplayComponent.js:218 msgid "Alignment" msgstr "" @@ -328,7 +328,7 @@ msgid "(Heading)" msgstr "" #: src/scripts/blocks/call-to-action/DisplayComponent.js:83 -#: src/scripts/blocks/image/DisplayComponent.js:286 +#: src/scripts/blocks/image/DisplayComponent.js:284 #: src/scripts/blocks/slider/DisplayComponent.js:322 msgid "(Content)" msgstr "" @@ -460,12 +460,12 @@ msgid "Edit File" msgstr "" #: src/scripts/blocks/header/DisplayComponent.js:104 -#: src/scripts/blocks/image/DisplayComponent.js:389 +#: src/scripts/blocks/image/DisplayComponent.js:387 msgid "Image" msgstr "" #: src/scripts/blocks/header/DisplayComponent.js:107 -#: src/scripts/blocks/image/DisplayComponent.js:392 +#: src/scripts/blocks/image/DisplayComponent.js:390 msgid "Video" msgstr "" @@ -475,7 +475,7 @@ msgid "Normal" msgstr "" #: src/scripts/blocks/header/DisplayComponent.js:141 -#: src/scripts/blocks/image/DisplayComponent.js:387 +#: src/scripts/blocks/image/DisplayComponent.js:385 msgid "Background Type" msgstr "" @@ -516,7 +516,7 @@ msgid "(Call to action)" msgstr "" #: src/scripts/blocks/header/DisplayComponent.js:80 -#: src/scripts/blocks/image/DisplayComponent.js:205 +#: src/scripts/blocks/image/DisplayComponent.js:203 #: src/scripts/blocks/slider/DisplayComponent.js:40 msgid "Centre" msgstr "" @@ -594,61 +594,61 @@ msgstr "" msgid "Responsive Iframe" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:144 +#: src/scripts/blocks/image/DisplayComponent.js:142 #: src/scripts/blocks/link/DisplayComponent.js:90 msgid "(Link Text)" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:152 +#: src/scripts/blocks/image/DisplayComponent.js:150 msgid "Remove Button" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:189 +#: src/scripts/blocks/image/DisplayComponent.js:187 msgid "Fixed Height (600px)" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:192 +#: src/scripts/blocks/image/DisplayComponent.js:190 msgid "Actual Height" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:214 +#: src/scripts/blocks/image/DisplayComponent.js:212 msgid "Image Style" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:221 +#: src/scripts/blocks/image/DisplayComponent.js:219 msgid "Only has an effect on images smaller than their container" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:280 +#: src/scripts/blocks/image/DisplayComponent.js:278 msgid "(Title)" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:297 +#: src/scripts/blocks/image/DisplayComponent.js:295 msgid "Add Button" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:321 +#: src/scripts/blocks/image/DisplayComponent.js:319 msgid "Choose Video" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:336 +#: src/scripts/blocks/image/DisplayComponent.js:334 #: src/scripts/packages/editor/PostFeaturedVideo.js:79 msgid "Replace Video" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:340 +#: src/scripts/blocks/image/DisplayComponent.js:338 msgid "Remove Video" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:404 +#: src/scripts/blocks/image/DisplayComponent.js:402 msgid "Display Overlay" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:409 +#: src/scripts/blocks/image/DisplayComponent.js:407 msgid "Enable Parallax" msgstr "" -#: src/scripts/blocks/image/DisplayComponent.js:429 +#: src/scripts/blocks/image/DisplayComponent.js:427 msgid "(Insert Caption, if required)" msgstr "" @@ -752,8 +752,8 @@ msgstr "" msgid "Add a links-with-icons block" msgstr "" -#: src/scripts/blocks/links-with-icons/InnerDisplayComponent.js:104 -#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:56 +#: src/scripts/blocks/links-with-icons/InnerDisplayComponent.js:105 +#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:55 msgid "Pick an image" msgstr "" @@ -779,12 +779,12 @@ msgid "Style" msgstr "" #: src/scripts/blocks/links-with-icons/InnerDisplayComponent.js:243 -#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:113 +#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:112 msgid "Icon Size" msgstr "" #: src/scripts/blocks/links-with-icons/InnerDisplayComponent.js:249 -#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:119 +#: src/scripts/blocks/logo-list/InnerDisplayComponent.js:118 msgid "Hide Image Credit Display" msgstr "" diff --git a/footer.php b/footer.php index ab582fc..1e138dc 100644 --- a/footer.php +++ b/footer.php @@ -23,7 +23,7 @@
  • - + diff --git a/header.php b/header.php index b49feca..42e3237 100644 --- a/header.php +++ b/header.php @@ -71,7 +71,7 @@ - + @@ -84,14 +84,14 @@ - @@ -99,7 +99,7 @@ diff --git a/partials/post/post-content.php b/partials/post/post-content.php index 5d2c3e2..08dd209 100644 --- a/partials/post/post-content.php +++ b/partials/post/post-content.php @@ -14,9 +14,9 @@
    taxonomy ); ?> - + - +

    diff --git a/partials/post/post-search.php b/partials/post/post-search.php index 43c3d14..8be0d91 100644 --- a/partials/post/post-search.php +++ b/partials/post/post-search.php @@ -15,9 +15,9 @@ taxonomy ); ?> - +

    -
    - +
    + diff --git a/phpcs.xml b/phpcs.xml index e34fb82..bb07b2f 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -8,7 +8,8 @@ - + + @@ -20,17 +21,20 @@ */block-translations.php - + + + + - + diff --git a/searchform.php b/searchform.php index 5245567..6f115c8 100644 --- a/searchform.php +++ b/searchform.php @@ -1,5 +1,5 @@ diff --git a/single.php b/single.php index eb18c0c..2eb6fd1 100644 --- a/single.php +++ b/single.php @@ -39,13 +39,13 @@ - name ); ?> + name ); ?> @@ -63,7 +63,7 @@ ?> - + @@ -104,9 +104,10 @@ /* translators: 1: posted in label, only visible to screen readers. 2: list of tags. */ printf( '%1$s %2$s', - __( 'Tags:', 'benenson' ), + esc_html__( 'Tags:', 'benenson' ), + // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped $tags_list - ); // WPCS: XSS OK. + ); } ?> diff --git a/src/scripts/blocks/image/DisplayComponent.js b/src/scripts/blocks/image/DisplayComponent.js index 6d12020..9460c95 100644 --- a/src/scripts/blocks/image/DisplayComponent.js +++ b/src/scripts/blocks/image/DisplayComponent.js @@ -1,5 +1,3 @@ -import React from 'react'; -import ReactDOM from 'react-dom'; import classnames from 'classnames'; const { __ } = wp.i18n; diff --git a/src/scripts/blocks/links-with-icons/InnerDisplayComponent.js b/src/scripts/blocks/links-with-icons/InnerDisplayComponent.js index 52ee42c..d1c268d 100644 --- a/src/scripts/blocks/links-with-icons/InnerDisplayComponent.js +++ b/src/scripts/blocks/links-with-icons/InnerDisplayComponent.js @@ -1,8 +1,6 @@ /** * Third-party */ -import React from 'react'; -import ReactDOM from 'react-dom'; import classnames from 'classnames'; import pick from 'lodash-es/pick'; @@ -10,18 +8,21 @@ import pick from 'lodash-es/pick'; * WordPress */ const { __ } = wp.i18n; -const { Component, Fragment } = wp.element; +const { + Component, + createRef, + findDOMNode, + Fragment, +} = wp.element; const { applyFilters } = wp.hooks; const { Button, CheckboxControl, PanelBody, - RangeControl, SelectControl, } = wp.components; const { InspectorControls, - InnerBlocks, MediaUpload, RichText, URLInputButton, @@ -54,7 +55,7 @@ export default class DisplayComponent extends Component { constructor(...params) { super(...params); - this.bigTextRef = React.createRef(); + this.bigTextRef = createRef(); } componentDidUpdate(props) { @@ -110,8 +111,7 @@ export default class DisplayComponent extends Component { return {}; } - const { setAttributes } = this.props; - const node = ReactDOM.findDOMNode(this.bigTextRef.current); + const node = findDOMNode(this.bigTextRef.current); const { length } = node.innerText; const styles = { diff --git a/src/scripts/blocks/logo-list/InnerDisplayComponent.js b/src/scripts/blocks/logo-list/InnerDisplayComponent.js index 41ab424..187d3fc 100644 --- a/src/scripts/blocks/logo-list/InnerDisplayComponent.js +++ b/src/scripts/blocks/logo-list/InnerDisplayComponent.js @@ -1,7 +1,6 @@ /** * Third-party */ -import React from 'react'; import classnames from 'classnames'; import pick from 'lodash-es/pick'; @@ -9,7 +8,7 @@ import pick from 'lodash-es/pick'; * WordPress */ const { __ } = wp.i18n; -const { Component, Fragment } = wp.element; +const { Component, createRef, Fragment } = wp.element; const { applyFilters } = wp.hooks; const { Button, @@ -26,7 +25,7 @@ export default class DisplayComponent extends Component { constructor(...params) { super(...params); - this.bigTextRef = React.createRef(); + this.bigTextRef = createRef(); } getImageButton = (openEvent) => {