adding github automation

Author: bignacio

.github/workflows/build-and-test.yaml

@@ -0,0 +1,24 @@
+name: Linux build
+
+on: [pull_request, push]
+
+jobs:
+  build-cpp-linux:
+    name: build-cpp-linux
+    runs-on: ubuntu-22.04
+    container:
+      image: ghcr.io/bignacio/docker-images/ubuntu-cpp-22.10:1
+      credentials:
+        username: bignacio
+        password: ${{ secrets.GHCR_PACKAGES_TOKEN }}
+    strategy:
+      matrix:
+        compiler: [g++-15, clang++-21]
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Build and test
+      env:
+        CXX: ${{matrix.compiler}}
+      run: ci-scripts/build-and-test.sh

CMakeLists.txt

@@ -37,12 +37,17 @@ set(CXX_PROJECT_RELEASE_FLAGS
     -DNDEBUG
 )
 
+
+
 if(CMAKE_BUILD_TYPE STREQUAL "Debug")
     list(APPEND CXX_PROJECT_FLAGS ${CXX_PROJECT_DEBUG_FLAGS})
 else()
     list(APPEND CXX_PROJECT_FLAGS ${CXX_PROJECT_RELEASE_FLAGS})
 endif()
 
+message(STATUS "Using compiler: ${CMAKE_CXX_COMPILER}")
+message(STATUS "Compiling with flags '${CXX_PROJECT_FLAGS}'")
+message(STATUS "Using CXX standard: ${CMAKE_CXX_STANDARD}")
 
 #'clang-diagnostic-*,clang-analyzer-*,clang-diagnostic-*,clang-analyzer-*,clang-diagnostic-*,clang-analyzer-*,-*,readability-*,clang-analyzer-core.*,clang-analyzer-cplusplus.*,modernize-*,performance-*,concurrency-*,cppcoreguidelines-*,bugprone*,-modernize-use-nodiscard,-performance-avoid-endl'
 # Set global clang-tidy parameters

ci-scripts/build-and-test-linux.sh

@@ -0,0 +1,17 @@
+#!/bin/bash
+
+set -e
+
+for build_type in Release Debug ; do
+    echo "Building type '${build_type}' compiler ${CXX}"
+    rm -rf build
+    cmake -B build -DCMAKE_BUILD_TYPE=${build_type}
+    make -j2 -C build
+
+    #just check the binary actually runs
+    build/src/replmk --help
+    build/tests/replmk-tests
+    build/tests/replmk-tests-msan
+    build/tests/replmk-tests-asan
+
+done

src/CMakeLists.txt

@@ -20,24 +20,14 @@ set(replmk_LIBS
     ftxui::screen
 )
 
-foreach (target replmk replmk-msan replmk-asan)
+foreach (target replmk)
     add_executable(${target} ${replmk_SRCS})
     target_include_directories(${target} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
 
     target_link_libraries(${target} PRIVATE ${replmk_LIBS})
     target_compile_options(${target} PRIVATE ${CXX_PROJECT_FLAGS})
 endforeach()
 
-
-# handle special targets
-if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-    target_compile_options(replmk-msan PRIVATE -fsanitize=memory -fno-omit-frame-pointer -fno-optimize-sibling-calls -fsanitize-memory-track-origins=2)
-    target_link_options(replmk-msan PRIVATE -fsanitize=memory -fsanitize-memory-track-origins=2)
-endif()
-
-target_compile_options(replmk-asan PRIVATE -fsanitize=address)
-target_link_options(replmk-asan PRIVATE -fsanitize=address)
-
 if(CLANG_TIDY)
     set_target_properties(replmk PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY};${CLANG_TIDY_PARAMS}")
 endif()

src/REPLMaker.cpp

@@ -65,9 +65,11 @@ auto runMain(int argc, char* argv[]) -> int { //NOLINT(cppcoreguidelines-avoid-c
     ("o,output-history-file", "Optional path to a file where to save the output history", cxxopts::value<std::string>())
     ("h,help", "Print usage");
 
+    options.allow_unrecognised_options();
+
     auto cmdOptionsParseResult = options.parse(argc, argv);
 
-    if (cmdOptionsParseResult.contains("help")) {
+    if (cmdOptionsParseResult.contains("help") or not cmdOptionsParseResult.unmatched().empty()) {
         std::cout << options.help() << std::endl;
         return 0;
     }

tests/CMakeLists.txt

@@ -1,4 +1,4 @@
-add_executable(replmk-tests
+set(replmk_tests_SRCS
     replmk_test.cpp
 
     Command_test.cpp
@@ -24,23 +24,40 @@ add_executable(replmk-tests
     ${CMAKE_CURRENT_SOURCE_DIR}/../src/REPLMaker.cpp
 )
 
-if(CLANG_TIDY)
-    set_target_properties(replmk-tests PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY};${CLANG_TIDY_PARAMS},-cppcoreguidelines-avoid-do-while")
-endif()
 
-target_include_directories(replmk-tests PRIVATE
+
+foreach (target replmk-tests replmk-tests-msan replmk-tests-asan)
+    add_executable(${target} ${replmk_tests_SRCS})
+    target_include_directories(${target} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
+
+    target_include_directories(${target} PRIVATE
     ${CMAKE_CURRENT_SOURCE_DIR}/../src
 )
 
-target_link_libraries(replmk-tests PRIVATE
-    doctest_with_main
+    target_link_libraries(${target} PRIVATE
+        doctest_with_main
 
-    yaml-cpp
-    cxxopts
+        yaml-cpp
+        cxxopts
 
-    ftxui::dom
-    ftxui::component
-    ftxui::screen
-)
+        ftxui::dom
+        ftxui::component
+        ftxui::screen
+    )
+
+    target_compile_options(${target} PRIVATE ${CXX_PROJECT_FLAGS})
+endforeach()
 
-target_compile_options(replmk-tests PRIVATE ${CXX_PROJECT_FLAGS})
+# handle special targets
+if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+    target_compile_options(replmk-tests-msan PRIVATE -fsanitize=memory -fno-omit-frame-pointer -fno-optimize-sibling-calls -fsanitize-memory-track-origins=2)
+    target_link_options(replmk-tests-msan PRIVATE -fsanitize=memory -fsanitize-memory-track-origins=2)
+endif()
+
+target_compile_options(replmk-tests-asan PRIVATE -fsanitize=address)
+target_link_options(replmk-tests-asan PRIVATE -fsanitize=address)
+
+
+if(CLANG_TIDY)
+    set_target_properties(replmk-tests PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY};${CLANG_TIDY_PARAMS},-cppcoreguidelines-avoid-do-while")
+endif()