Skip to content

feat: Add coordinate_system_zero_based parameter to all table providers #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwiewior wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Add coordinate_system_zero_based parameter to all table providers #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32541d
feat: Add coordinate_system_zero_based parameter to all table providers
mwiewior Dec 6, 2025
288710c
feat: Add coordinate_system_zero_based to BgzfGffTableProvider
mwiewior Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ jobs:
echo "✓ Copied current benchmark framework to baseline tag"

- name: Build Baseline Benchmark Runner
id: build_baseline_linux
if: ${{ needs.prepare.outputs.baseline_tag != 'none' }}
continue-on-error: true
run: |
cargo build --release --package datafusion-bio-benchmarks-runner
env:
Expand All @@ -173,13 +175,19 @@ jobs:
# SCCACHE_GHA_ENABLED: "true" # Temporarily disabled

- name: Run Baseline Benchmarks
if: ${{ needs.prepare.outputs.baseline_tag != 'none' }}
if: ${{ needs.prepare.outputs.baseline_tag != 'none' && steps.build_baseline_linux.outcome == 'success' }}
run: |
mkdir -p baseline_results
./target/release/benchmark-runner benchmarks/configs/gff.yml --output-dir baseline_results
env:
RUST_LOG: info

- name: Skip Baseline Notice
if: ${{ needs.prepare.outputs.baseline_tag != 'none' && steps.build_baseline_linux.outcome != 'success' }}
run: |
echo "⚠️ Baseline benchmarks skipped due to API incompatibility with baseline tag"
echo "This typically happens when table provider function signatures have changed"

# Reset Cargo.lock before target build (keep compiled artifacts)
- name: Reset Cargo.lock
if: ${{ needs.prepare.outputs.baseline_tag != 'none' }}
Expand Down Expand Up @@ -294,7 +302,9 @@ jobs:
echo "✓ Copied current benchmark framework to baseline tag"

- name: Build Baseline Benchmark Runner
id: build_baseline_macos
if: ${{ needs.prepare.outputs.baseline_tag != 'none' }}
continue-on-error: true
run: |
cargo build --release --package datafusion-bio-benchmarks-runner
env:
Expand All @@ -303,13 +313,19 @@ jobs:
# SCCACHE_GHA_ENABLED: "true" # Temporarily disabled

- name: Run Baseline Benchmarks
if: ${{ needs.prepare.outputs.baseline_tag != 'none' }}
if: ${{ needs.prepare.outputs.baseline_tag != 'none' && steps.build_baseline_macos.outcome == 'success' }}
run: |
mkdir -p baseline_results
./target/release/benchmark-runner benchmarks/configs/gff.yml --output-dir baseline_results
env:
RUST_LOG: info

- name: Skip Baseline Notice
if: ${{ needs.prepare.outputs.baseline_tag != 'none' && steps.build_baseline_macos.outcome != 'success' }}
run: |
echo "⚠️ Baseline benchmarks skipped due to API incompatibility with baseline tag"
echo "This typically happens when table provider function signatures have changed"

# Reset Cargo.lock before target build (keep compiled artifacts)
- name: Reset Cargo.lock
if: ${{ needs.prepare.outputs.baseline_tag != 'none' }}
Expand Down
Loading
Loading