Feature request: Merge OneKey connection support from PR #826

[wabicai]

Summary

PR #826 adds OneKey device support to HWI, but it is still open and not merged.

PR: #826

Request

Could maintainers please help review and merge OneKey connection support, or provide a clear list of blockers required for merge?

Why this matters

• OneKey users currently have limited/no official HWI connectivity path.
• This support would improve hardware wallet coverage and user choice in the Bitcoin ecosystem.
• The PR already includes implementation, tests, docs, and Linux udev rules updates.

Included in PR #826

• Add OneKey device support implementation (hwilib/devices/onekey.py)
• Device detection and USB IDs handling
• udev rules for OneKey devices
• Tests for OneKey behavior
• Device documentation updates

Questions for maintainers

1. Is the current approach acceptable for upstream architecture?
2. Are there specific API/behavior/test requirements still missing?
3. If merge is not currently possible, what minimal changes are required to proceed?

Thanks for your review and guidance.

[wabicai]

Thanks for taking a look. Adding concrete details that may help review:

• Scope in PR Add OneKey device support  #826:

  • Adds dedicated OneKey device module (hwilib/devices/onekey.py)
  • Adds OneKey Linux udev rules (hwilib/udev/51-usb-onekey.rules)
  • Adds unit tests for detection/enumeration/lock-state behavior (test/test_onekey.py)
  • Adds docs entry in supported devices (docs/devices/index.rst)

• Current test coverage in this PR includes:

  • USB ID detection paths (dict/webusb-like object)
  • Transport/device identification fallbacks
  • Model-specific locked-device warning behavior (e.g. classic vs pro/touch)
  • Enumerate behavior for locked/unlocked states and fingerprint availability

• Linux udev IDs included:

  • 1209:53c0, 1209:53c1, 1209:4f4a, 1209:4f4b

• Upstream support policy alignment:

  • We can commit to vendor-side maintenance for this integration and respond to compatibility issues in follow-up PRs.

If there are still blockers, a checklist from maintainers (API style, behavior expectations, missing tests, CI requirements) would be very helpful and we can address items one by one quickly.

[achow101]

It will be merged when it is ready, after people have reviewed it. Stop opening LLM generated issues and PRs.