cache historical price data

Author: bitrequest

assets_js_bitrequest_monitors.js

@@ -904,14 +904,13 @@ function update_transaction_count(status_panel, count) {
 
 // Triggers historical fiat data retrieval for transactions based on confirmation status
 function init_fiat_history(rd, rdo, latestconf, latest_input, firstinput) {
-    const cache_value = latest_input + latestconf.toString(), // only update on change
+    const cache_value = latest_input + latestconf, // only update on change
         cache_prefix = "historic_" + rd.requestid,
         cache_timestamp = br_get_session(cache_prefix), // set to small amount to trigger lookup exchange rates
-        cache_session = cache_timestamp || 1,
-        latest_input_slice = cache_timestamp ? cache_session.slice(0, 13) : latest_input,
-        latestinput = parseInt(latest_input_slice),
-        historic_cache = parseInt(cache_session);
+        historic_cache = parseInt(cache_timestamp) || 1;
     if (cache_value > historic_cache) { //new input detected; call historic api
+        const time_past = cache_value - historic_cache,
+            latestinput = (time_past > 600000) ? latest_input : historic_cache; // refresh cache only every 10 minutes
         br_remove_session(cache_prefix); // remove historic price cache
         const historic_payload = $.extend(rd, {
                 latestinput,
@@ -1160,8 +1159,7 @@ function fetch_crypto_rates(rd, rdo, fiat_api, api_list, api, currency_rate, usd
                     "lightning": rd.lightning
                 }, false);
                 if (pending !== "no") {
-                    const cache_value = latest_input + latest_confirm.toString();
-                    br_set_session("historic_" + rd.requestid, cache_value); // 'cache' historic data
+                    br_set_session("historic_" + rd.requestid, latest_input + latest_confirm); // 'cache' historic data
                 }
                 finalize_request_state(rdo);
                 return
@@ -1349,25 +1347,25 @@ function check_api(payment) {
 
 // Formats and normalizes request data for transaction processing
 function tx_data(rd) {
-    const request_id = rd.requestid,
-        request_list = $("#" + request_id),
+    const requestid = rd.requestid,
+        thislist = $("#" + requestid),
         request_date = rd.inout === "incoming" ? rd.timestamp : rd.requestdate,
         request_timestamp = request_date - 30000, // 30 seconds compensation for unexpected results
         get_confirmations = rd.set_confirmations,
-        set_confirmations = get_confirmations ? parseInt(get_confirmations) : 1,
-        is_canceled = rd.status === "canceled",
-        pending_status = is_canceled ? "scanning" : rd.pending,
-        status_panel = request_list.find(".pmetastatus"),
-        transaction_list = request_list.find("ul.transactionlist");
+        setconfirmations = get_confirmations ? parseInt(get_confirmations) : 1,
+        canceled = rd.status === "canceled",
+        pending = canceled ? "scanning" : rd.pending,
+        statuspanel = thislist.find(".pmetastatus"),
+        transactionlist = thislist.find("ul.transactionlist");
     return {
-        "requestid": request_id,
-        "thislist": request_list,
-        "request_timestamp": request_timestamp,
-        "setconfirmations": set_confirmations,
-        "canceled": is_canceled,
-        "pending": pending_status,
-        "statuspanel": status_panel,
-        "transactionlist": transaction_list,
+        requestid,
+        thislist,
+        request_timestamp,
+        setconfirmations,
+        canceled,
+        pending,
+        statuspanel,
+        transactionlist,
         "source": "requests",
         "cachetime": 25
     }