Adding retry when agreements missing (#267)

Author: lpusok

autocodesign/devportalclient/appstoreconnect/appstoreconnect.go

@@ -7,6 +7,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -78,6 +79,16 @@ func NewRetryableHTTPClient() *http.Client {
 			return true, nil
 		}
 
+		if resp != nil && resp.StatusCode == http.StatusForbidden {
+			var apiError *ErrorResponse
+			if ok := errors.As(checkResponse(resp), &apiError); ok {
+				if apiError.IsRequiredAgreementMissingOrExpired() {
+					log.Warnf("Received error FORBIDDEN.REQUIRED_AGREEMENTS_MISSING_OR_EXPIRED (status 403), retrying request...")
+					return true, nil
+				}
+			}
+		}
+
 		if resp != nil && resp.StatusCode == http.StatusTooManyRequests {
 			message := "Received HTTP 429 Too Many Requests"
 			if rateLimit := resp.Header.Get("X-Rate-Limit"); rateLimit != "" {

autocodesign/devportalclient/appstoreconnect/error.go

@@ -49,6 +49,22 @@ func (r ErrorResponse) IsCursorInvalid() bool {
 	return false
 }
 
+// IsRequiredAgreementMissingOrExpired ...
+func (r ErrorResponse) IsRequiredAgreementMissingOrExpired() bool {
+	// status code: 403
+	// code: FORBIDDEN.REQUIRED_AGREEMENTS_MISSING_OR_EXPIRED
+	// title: A required agreement is missing or has expired.
+	// detail: This request requires an in-effect agreement that has not been signed or has expired.
+
+	for _, err := range r.Errors {
+		if err.Code == "FORBIDDEN.REQUIRED_AGREEMENTS_MISSING_OR_EXPIRED" {
+			return true
+		}
+	}
+
+	return false
+}
+
 // DeviceRegistrationError ...
 type DeviceRegistrationError struct {
 	Reason string