Extend supported test artifacts with text files [CI-5161] (#234)

* Extend supported test artifacts with text files [CI-5161]

Author: zsolt-vicze

main.go

@@ -470,9 +470,9 @@ func deployTestResults(config Config, logger loggerV2.Logger) {
 		if i == 0 {
 			logger.Printf("List of test results:")
 		}
-		if len(result.ImagePaths) > 0 {
-			logger.Printf("- %s (generated by the %s) with %d attachment(s):", result.Name, stepNameWithIndex(result.StepInfo), len(result.ImagePaths))
-			for _, pth := range result.ImagePaths {
+		if len(result.AttachmentPaths) > 0 {
+			logger.Printf("- %s (generated by the %s) with %d attachment(s):", result.Name, stepNameWithIndex(result.StepInfo), len(result.AttachmentPaths))
+			for _, pth := range result.AttachmentPaths {
 				logger.Printf("  - %s", pth)
 			}
 		} else {

test/test.go

@@ -50,10 +50,10 @@ type UploadResponse struct {
 
 // Result ...
 type Result struct {
-	Name       string
-	XMLContent []byte
-	ImagePaths []string
-	StepInfo   models.TestResultStepInfo
+	Name            string
+	XMLContent      []byte
+	AttachmentPaths []string
+	StepInfo        models.TestResultStepInfo
 }
 
 // Results ...
@@ -95,7 +95,7 @@ func httpCall(apiToken, method, url string, input io.Reader, output interface{},
 	return nil
 }
 
-func findImages(testDir string) (imageFilePaths []string) {
+func findSupportedAttachments(testDir string) (imageFilePaths []string) {
 	for _, ext := range testasset.AssetTypes {
 		if paths, err := filepath.Glob(filepath.Join(testDir, "*"+ext)); err == nil {
 			imageFilePaths = append(imageFilePaths, paths...)
@@ -227,15 +227,15 @@ func ParseTestResults(testsRootDir string, useLegacyXCResultExtractionMethod boo
 					xmlData = append([]byte(`<?xml version="1.0" encoding="UTF-8"?>`+"\n"), xmlData...)
 
 					// so here I will have image paths, xml data, and step info per test dir in a bundle info
-					images := findImages(testPhaseDirPath)
+					attachments := findSupportedAttachments(testPhaseDirPath)
 
-					logger.Debugf("found images: %d", len(images))
+					logger.Debugf("found attachments: %d", len(attachments))
 
 					results = append(results, Result{
-						Name:       testInfo.Name,
-						XMLContent: xmlData,
-						ImagePaths: images,
-						StepInfo:   *stepInfo,
+						Name:            testInfo.Name,
+						XMLContent:      xmlData,
+						AttachmentPaths: attachments,
+						StepInfo:        *stepInfo,
 					})
 				}
 			}
@@ -257,7 +257,7 @@ func (results Results) Upload(apiToken, endpointBaseURL, appSlug, buildSlug stri
 			Name: result.Name,
 			Step: result.StepInfo,
 		}
-		for _, asset := range result.ImagePaths {
+		for _, asset := range result.AttachmentPaths {
 			fi, err := os.Stat(asset)
 			if err != nil {
 				return fmt.Errorf("failed to get file info for %s: %w", asset, err)
@@ -286,7 +286,7 @@ func (results Results) Upload(apiToken, endpointBaseURL, appSlug, buildSlug stri
 		}
 
 		for _, upload := range uploadResponse.Assets {
-			for _, file := range result.ImagePaths {
+			for _, file := range result.AttachmentPaths {
 				if filepath.Base(file) == upload.FileName {
 					fi, err := os.Open(file)
 					if err != nil {

test/test_test.go

@@ -7,6 +7,7 @@ import (
 	"os"
 	"path"
 	"path/filepath"
+	"strings"
 	"testing"
 	"time"
 
@@ -51,9 +52,9 @@ func Test_Upload(t *testing.T) {
 
 	results := Results{
 		Result{
-			XMLContent: testXMLContent,
-			StepInfo:   testStepInfo,
-			ImagePaths: testAssetPaths,
+			XMLContent:      testXMLContent,
+			StepInfo:        testStepInfo,
+			AttachmentPaths: testAssetPaths,
 		},
 	}
 
@@ -218,7 +219,7 @@ func Test_ParseXctestResults(t *testing.T) {
 		if err := createDummyFilesInDirWithContent(phaseDir, `{"name": "test name"}`, []string{"test-info.json"}); err != nil {
 			t.Fatal("failed to create dummy files in dir, error:", err)
 		}
-		if err := createDummyFilesInDirWithContent(phaseDir, "test content", []string{"image.png", "image3.jpeg", "dirty.gif", "dirty.html"}); err != nil {
+		if err := createDummyFilesInDirWithContent(phaseDir, "test content", []string{"image.png", "image3.jpeg", "dirty.gif", "dirty.html", "logs.txt", "zzz.log"}); err != nil {
 			t.Fatal("failed to create dummy files in dir, error:", err)
 		}
 		if err := createDummyFilesInDirWithContent(phaseDir, sampleIOSXmlOutput, []string{"result.xml"}); err != nil {
@@ -234,6 +235,12 @@ func Test_ParseXctestResults(t *testing.T) {
 		}
 
 		assert.Equal(t, sampleIOSXmlOutput, string(bundle[0].XMLContent))
+		// Check if the attachments are correctly by the end of paths
+		assert.Equal(t, 4, len(bundle[0].AttachmentPaths))
+		assert.True(t, strings.HasSuffix(bundle[0].AttachmentPaths[0], "image3.jpeg"))
+		assert.True(t, strings.HasSuffix(bundle[0].AttachmentPaths[1], "image.png"))
+		assert.True(t, strings.HasSuffix(bundle[0].AttachmentPaths[2], "logs.txt"))
+		assert.True(t, strings.HasSuffix(bundle[0].AttachmentPaths[3], "zzz.log"))
 	}
 
 	// creating ios test results

test/testasset/testasset.go

@@ -5,7 +5,7 @@ import (
 	"slices"
 )
 
-var AssetTypes = []string{".jpg", ".jpeg", ".png"}
+var AssetTypes = []string{".jpg", ".jpeg", ".png", ".txt", ".log"}
 
 func IsSupportedAssetType(fileName string) bool {
 	ext := filepath.Ext(fileName)