feat(sso-persisted-grants) [PM-23572]: Add cache key constant and remove explicit skip distributed cache on set for default configuration.

Author: enmande

bitwarden_license/src/Sso/IdentityServer/DistributedCachePersistedGrantStore.cs

@@ -1,4 +1,5 @@
-using Duende.IdentityServer.Models;
+using Bit.Sso.Utilities;
+using Duende.IdentityServer.Models;
 using Duende.IdentityServer.Stores;
 using ZiggyCreatures.Caching.Fusion;
 
@@ -23,7 +24,7 @@ public class DistributedCachePersistedGrantStore : IPersistedGrantStore
     private readonly IFusionCache _cache;
 
     public DistributedCachePersistedGrantStore(
-        [FromKeyedServices("sso-grants")] IFusionCache cache)
+        [FromKeyedServices(PersistedGrantsDistributedCacheConstants.CacheKey)] IFusionCache cache)
     {
         _cache = cache;
     }
@@ -96,11 +97,6 @@ public async Task StoreAsync(PersistedGrant grant)
         await _cache.SetAsync(
             grant.Key,
             grant,
-            new FusionCacheEntryOptions
-            {
-                Duration = duration,
-                // Keep distributed cache enabled for multi-instance scenarios
-                // When Redis isn't configured, FusionCache gracefully uses only L1 (in-memory)
-            }.SetSkipDistributedCache(false, false));
+            new FusionCacheEntryOptions { Duration = duration });
     }
 }

bitwarden_license/src/Sso/Utilities/PersistedGrantsDistributedCacheConstants.cs

@@ -0,0 +1,10 @@
+namespace Bit.Sso.Utilities;
+
+public static class PersistedGrantsDistributedCacheConstants
+{
+    /// <summary>
+    /// The SSO Persisted Grant cache key. Identifies the keyed service consumed by the SSO Persisted Grant Store as
+    /// well as the cache key/namespace for grant storage.
+    /// </summary>
+    public const string CacheKey = "sso-grants";
+}

bitwarden_license/src/Sso/Utilities/ServiceCollectionExtensions.cs

@@ -79,11 +79,11 @@ public static IIdentityServerBuilder AddSsoIdentityServerServices(this IServiceC
             .AddIdentityServerCertificate(env, globalSettings);
 
         // PM-23572
-        // Register named FusionCache for SSO authorization code grants
+        // Register named FusionCache for SSO authorization code grants.
         // Provides separation of concerns and automatic Redis/in-memory negotiation
         // .AddInMemoryCaching should still persist above; this handles configuration caching, etc.,
         // and is separate from this keyed service, which only serves grant negotiation.
-        services.AddExtendedCache("sso-grants", globalSettings);
+        services.AddExtendedCache(PersistedGrantsDistributedCacheConstants.CacheKey, globalSettings);
 
         // Store authorization codes in distributed cache for horizontal scaling
         // Uses named FusionCache which gracefully degrades to in-memory when Redis isn't configured