added a lint, corrected (almost) everything according to it

Author: blackmarllborooo

.golangci.yml

@@ -0,0 +1,36 @@
+run:
+  tests: true
+  skip-dirs:
+    - build
+
+output:
+  format: colored-line-number
+  print-issued-lines: true
+  print-linter-name: true
+  unique-by-line: true
+  sort-results: true
+
+linters:
+  disable-all: true
+  enable:
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - typecheck
+    - unused
+    - cyclop
+    - dupl
+    - dupword
+    - funlen
+    - lll
+    - gochecknoglobals
+    - goconst
+    - gocritic
+    - gocyclo
+    - godot
+    - gosec
+    - nakedret
+    - nestif
+    - stylecheck
+    - varnamelen

Makefile

@@ -34,4 +34,8 @@ test:
 
 .PHONE: clear
 clear:
-	sh ./script/clear.sh
+	sh ./script/clear.sh
+
+.PHONY: lint
+lint:
+	golangci-lint run

internal/app/dir/dir.go

@@ -12,7 +12,7 @@ import (
 
 const perm = 0755 // Access rights to create folders
 
-// Constants with the name of the project subdirectories
+// Constants with the name of the project subdirectories.
 const (
 	cmdDir      = "cmd"
 	pkgDir      = "pkg"
@@ -60,6 +60,8 @@ func (d *Dirs) createProjectDir() error {
 	return nil
 }
 
+// TODO calculated cyclomatic complexity for function createProjectDirs is 13,
+// max is 10.
 func (d *Dirs) createProjectDirs() error {
 	projectDirs := [4]string{cmdDir, pkgDir, internalDir, cfgDir}
 
@@ -78,15 +80,16 @@ func (d *Dirs) createProjectDirs() error {
 		}
 
 		// depending on the current directory being created, create files or subdirectories.
-		if currentDir == cmdDir {
+		switch currentDir {
+		case cmdDir:
 			if err := d.file.GenerateMainFile(dir + "/" + d.projectName + ".go"); err != nil {
 				return err
 			}
-		} else if currentDir == internalDir {
+		case internalDir:
 			if err := d.createInternalSubDir(); err != nil {
 				return err
 			}
-		} else if currentDir == cfgDir {
+		case cfgDir:
 			if err := d.file.GenerateCfgFile(dir); err != nil {
 				return err
 			}

internal/app/file/file.go

@@ -15,18 +15,18 @@ func NewFile() *File {
 }
 
 func (fl File) createAndWriteFile(dir, content string) error {
-	f, err := os.Create(dir)
+	file, err := os.Create(dir)
 	if err != nil {
 		return err
 	}
 	defer func() {
-		err = f.Close()
+		err = file.Close()
 	}()
 	if err != nil {
 		return err
 	}
 
-	if _, err := f.WriteString(content); err != nil {
+	if _, err := file.WriteString(content); err != nil {
 		return err
 	}
 

internal/pkg/args/tests/args_test.go

@@ -28,13 +28,13 @@ func TestGetProjectName(t *testing.T) {
 			t.Fatalf("Expected an error, got nil")
 		}
 
-		wd, err := os.Getwd()
+		pwd, err := os.Getwd()
 		if err != nil {
 			t.Fatalf("Fail to get current directory: %s", err.Error())
 		}
 
-		if projectName != wd {
-			t.Fatalf("Expected project name to be: %s, got: %s", wd, projectName)
+		if projectName != pwd {
+			t.Fatalf("Expected project name to be: %s, got: %s", pwd, projectName)
 		}
 
 		if !isCurrentDir {

pkg/version/tests/version_test.go

@@ -9,7 +9,7 @@ import (
 )
 
 func TestGetVersion(t *testing.T) {
-	v, err := version.GoVersion()
+	vers, err := version.GoVersion()
 	if err != nil {
 		t.Fatalf("GoVersion() returned an error: %v", err)
 	}
@@ -19,24 +19,24 @@ func TestGetVersion(t *testing.T) {
 	t.Log("verify that the version string is in the correct format")
 	{
 		re := regexp.MustCompile(`go \d+\.\d+(\.\d+)?`)
-		if !re.MatchString(v) {
-			t.Fatalf("GoVersion() returned an invalid version string: %s", v)
+		if !re.MatchString(vers) {
+			t.Fatalf("GoVersion() returned an invalid version string: %s", vers)
 		}
 	}
 
 	t.Log("verify that the version string is properly formatted")
 	{
-		versionDigits := strings.TrimPrefix(v, "go")
+		versionDigits := strings.TrimPrefix(vers, "go")
 		versionParts = strings.Split(versionDigits, ".")
 		if len(versionParts) < 2 || len(versionParts) > 3 {
-			t.Fatalf("GoVersion() returned an invalid version string: %s", v)
+			t.Fatalf("GoVersion() returned an invalid version string: %s", vers)
 		}
 	}
 
 	t.Log("verify that the version string starts with \"go\"")
 	{
-		if !strings.HasPrefix(v, "go") {
-			t.Fatalf("GoVersion() returned an invalid version string: %s", v)
+		if !strings.HasPrefix(vers, "go") {
+			t.Fatalf("GoVersion() returned an invalid version string: %s", vers)
 		}
 	}