NFSv4: Fix memory leak in nfs4_set_security_label

PlaidCat · PlaidCat · commit 6519a8f523bf · 2024-09-12T13:28:09.000-04:00
jira LE-1907 cve CVE-2024-41076 Rebuild_History Non-Buildable kernel-5.14.0-427.33.1.el9_4 commit-author Dmitry Mastykin <mastichi@gmail.com> commit aad1147 We leak nfs_fattr and nfs4_label every time we set a security xattr. Signed-off-by: Dmitry Mastykin <mastichi@gmail.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> (cherry picked from commit aad1147) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
@@ -6243,6 +6243,7 @@ nfs4_set_security_label(struct inode *inode, const void *buf, size_t buflen)
 	if (status == 0)
 		nfs_setsecurity(inode, fattr);
 
+	nfs_free_fattr(fattr);
 	return status;
 }
 #endif	/* CONFIG_NFS_V4_SECURITY_LABEL */

Original file line number	Diff line number	Diff line change
`@@ -6243,6 +6243,7 @@ nfs4_set_security_label(struct inode inode, const void buf, size_t buflen)`
`6243`	`6243`	`if (status == 0)`
`6244`	`6244`	`nfs_setsecurity(inode, fattr);`
`6245`	`6245`
	`6246`	`+ nfs_free_fattr(fattr);`
`6246`	`6247`	`return status;`
`6247`	`6248`	`}`
`6248`	`6249`	`#endif /* CONFIG_NFS_V4_SECURITY_LABEL */`