Skip to content

Commit 015674e

Browse files
committed
chore: Add missed files
1 parent 5ef36fa commit 015674e

File tree

15 files changed

+12
-175
lines changed

15 files changed

+12
-175
lines changed

i18n/en-US.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ be.collaboratedFolder = Collaborated Folder
100100
be.collapse = Collapse
101101
# Label for complete state.
102102
be.complete = Complete
103+
# Text shown to indicate the number of files selected
104+
be.contentExplorer.numFilesSelected = {numSelected, plural, =0 {0 files selected} one {1 file selected} other {# files selected} }
103105
# Text shown to users when opening the content insights flyout and there is an error
104106
be.contentInsights.contentAnalyticsErrorText = There was a problem loading content insights. Please try again.
105107
# Message shown when the user does not have access to view content insights anymore
@@ -1066,8 +1068,6 @@ boxui.contentExplorer.move = Move
10661068
boxui.contentExplorer.name = Name
10671069
# Text shown on button used to create a new folder
10681070
boxui.contentExplorer.newFolder = New Folder
1069-
# Text shown to indicate the number of files selected
1070-
boxui.contentExplorer.numFilesSelected = {numSelected, plural, =0 {0 files selected} one {1 file selected} other {# files selected} }
10711071
# Text shown to indicate the number of folders selected
10721072
boxui.contentExplorer.numFoldersSelected = {numSelected, plural, =0 {0 folders selected} one {1 folder selected} other {# folders selected} }
10731073
# Text shown to indicate the number of items selected with Include Subfolders feature

package.json

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -124,33 +124,19 @@
124124
"@babel/preset-typescript": "^7.24.7",
125125
"@babel/template": "^7.24.7",
126126
"@babel/types": "^7.24.7",
127-
<<<<<<< HEAD
128127
"@box/blueprint-web": "12.43.0",
129128
"@box/blueprint-web-assets": "4.61.5",
130129
"@box/box-ai-agent-selector": "^0.48.5",
131-
=======
132-
"@box/blueprint-web": "^12.41.0",
133-
"@box/blueprint-web-assets": "^4.60.9",
134-
"@box/box-ai-agent-selector": "^0.41.10",
135-
>>>>>>> b49985c8b (feat(metadata-view): Add MetadataView V2)
136130
"@box/box-ai-content-answers": "^0.124.1",
137131
"@box/box-item-type-selector": "^0.61.12",
138132
"@box/cldr-data": "^34.2.0",
139133
"@box/combobox-with-api": "^0.34.9",
140134
"@box/frontend": "^11.0.1",
141-
<<<<<<< HEAD
142135
"@box/item-icon": "^0.17.0",
143136
"@box/languages": "^1.0.0",
144137
"@box/metadata-editor": "^0.122.12",
145138
"@box/metadata-filter": "^1.16.12",
146139
"@box/metadata-view": "^0.29.4",
147-
=======
148-
"@box/item-icon": "^0.16.3",
149-
"@box/languages": "^1.0.0",
150-
"@box/metadata-editor": "^0.122.0",
151-
"@box/metadata-filter": "^1.16.3",
152-
"@box/metadata-view": "^0.28.0",
153-
>>>>>>> b49985c8b (feat(metadata-view): Add MetadataView V2)
154140
"@box/react-virtualized": "^9.22.3-rc-box.10",
155141
"@box/types": "^0.2.1",
156142
"@cfaester/enzyme-adapter-react-18": "^0.8.0",
@@ -307,31 +293,17 @@
307293
"webpack-dev-server": "^5.2.1"
308294
},
309295
"peerDependencies": {
310-
<<<<<<< HEAD
311296
"@box/blueprint-web": "12.43.0",
312297
"@box/blueprint-web-assets": "4.61.5",
313298
"@box/box-ai-agent-selector": "^0.48.5",
314-
=======
315-
"@box/blueprint-web": "^12.41.0",
316-
"@box/blueprint-web-assets": "^4.60.9",
317-
"@box/box-ai-agent-selector": "^0.41.10",
318-
>>>>>>> b49985c8b (feat(metadata-view): Add MetadataView V2)
319299
"@box/box-ai-content-answers": "^0.124.1",
320300
"@box/box-item-type-selector": "^0.61.12",
321301
"@box/cldr-data": ">=34.2.0",
322302
"@box/combobox-with-api": "^0.34.9",
323-
<<<<<<< HEAD
324303
"@box/item-icon": "^0.17.0",
325304
"@box/metadata-editor": "^0.122.12",
326305
"@box/metadata-filter": "^1.16.12",
327306
"@box/metadata-view": "^0.29.4",
328-
=======
329-
"@box/item-icon": "^0.16.3",
330-
"@box/languages": "^1.0.0",
331-
"@box/metadata-editor": "^0.122.0",
332-
"@box/metadata-filter": "^1.16.3",
333-
"@box/metadata-view": "^0.28.0",
334-
>>>>>>> b49985c8b (feat(metadata-view): Add MetadataView V2)
335307
"@box/react-virtualized": "^9.22.3-rc-box.10",
336308
"@box/types": "^0.2.1",
337309
"@hapi/address": "^2.1.4",

scripts/jest/jest.config.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ module.exports = {
2626
testMatch: ['**/__tests__/**/*.test.+(js|jsx|ts|tsx)'],
2727
testPathIgnorePatterns: ['stories.test.js$', 'stories.test.tsx$', 'stories.test.d.ts'],
2828
transformIgnorePatterns: [
29-
<<<<<<< HEAD
3029
'node_modules/(?!(@box/react-virtualized/dist/es|@box/cldr-data|@box/blueprint-web|@box/blueprint-web-assets|@box/metadata-editor|@box/box-ai-content-answers|@box/box-ai-agent-selector|@box/item-icon|@box/combobox-with-api|@box/tree|@box/metadata-filter|@box/metadata-view|@box/types|@box/box-item-type-selector)/)',
31-
=======
32-
'node_modules/(?!(@box/react-virtualized/dist/es|@box/cldr-data|@box/blueprint-web|@box/blueprint-web-assets|@box/metadata-editor|@box/box-ai-content-answers|@box/box-ai-agent-selector|@box/item-icon|@box/combobox-with-api|@box/tree|@box/metadata-filter|@box/metadata-view|@box/types)/)',
33-
>>>>>>> b49985c8b (feat(metadata-view): Add MetadataView V2)
3430
],
3531
};

src/common/types/core.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import {
3434
PERMISSION_CAN_DOWNLOAD,
3535
PERMISSION_CAN_PREVIEW,
3636
} from '../../constants';
37-
import type { MetadataType, MetadataTemplate } from './metadata';
37+
import type { MetadataType } from './metadata';
3838

3939
type Token = null | typeof undefined | string | Function;
4040
type TokenReadWrite = { read: string, write?: string };
@@ -394,7 +394,6 @@ type Collection = {
394394
breadcrumbs?: Array<Crumb>,
395395
id?: string,
396396
items?: Array<BoxItem>,
397-
metadataTemplate?: MetadataTemplate,
398397
name?: string,
399398
nextMarker?: ?string,
400399
offset?: number,

src/elements/common/messages.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1090,7 +1090,7 @@ const messages = defineMessages({
10901090
defaultMessage: 'Personal Folder',
10911091
},
10921092
numFilesSelected: {
1093-
id: 'boxui.contentExplorer.numFilesSelected',
1093+
id: 'be.contentExplorer.numFilesSelected',
10941094
description: 'Text shown to indicate the number of files selected',
10951095
defaultMessage: `
10961096
{numSelected, plural,

src/elements/common/sub-header/SubHeader.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export interface SubHeaderProps {
2525
gridMinColumns?: number;
2626
isSmall: boolean;
2727
maxGridColumnCountForWidth?: number;
28-
metadataAncestorFolderName?: string | null;
2928
metadataViewTitle?: string;
3029
onClearSelectedKeys: () => void;
3130
onCreate: () => void;
@@ -51,7 +50,6 @@ const SubHeader = ({
5150
gridMaxColumns = 0,
5251
gridMinColumns = 0,
5352
maxGridColumnCountForWidth = 0,
54-
metadataAncestorFolderName,
5553
metadataViewTitle,
5654
onGridViewSliderChange = noop,
5755
isSmall,
@@ -96,7 +94,6 @@ const SubHeader = ({
9694
<SubheaderLeftMetadataViewV2
9795
api={api}
9896
currentCollection={currentCollection}
99-
metadataAncestorFolderName={metadataAncestorFolderName}
10097
metadataViewTitle={metadataViewTitle}
10198
onClearSelectedKeys={onClearSelectedKeys}
10299
selectedKeys={selectedKeys}

src/elements/common/sub-header/SubHeaderLeftMetadataViewV2.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,13 @@ import './SubHeaderLeftMetadataViewV2.scss';
1111
interface SubHeaderLeftMetadataViewV2Props {
1212
api?: API;
1313
currentCollection: Collection;
14-
metadataAncestorFolderName?: string | null;
1514
metadataViewTitle?: string;
1615
onClearSelectedKeys?: () => void;
1716
selectedKeys: Selection;
1817
}
1918

2019
const SubHeaderLeftMetadataViewV2 = (props: SubHeaderLeftMetadataViewV2Props) => {
21-
const { currentCollection, metadataAncestorFolderName, metadataViewTitle, onClearSelectedKeys, selectedKeys } =
22-
props;
20+
const { currentCollection, metadataViewTitle, onClearSelectedKeys, selectedKeys } = props;
2321
const { formatMessage } = useIntl();
2422

2523
// Generate selected item text based on selected keys
@@ -59,10 +57,10 @@ const SubHeaderLeftMetadataViewV2 = (props: SubHeaderLeftMetadataViewV2Props) =>
5957
);
6058
}
6159

62-
// Case 3: No selected items - show title if provided, otherwise show ancestor folder name
60+
// Case 3: No selected items - show title
6361
return (
6462
<Text as="h1" variant="titleXLarge">
65-
{metadataViewTitle ?? metadataAncestorFolderName}
63+
{metadataViewTitle}
6664
</Text>
6765
);
6866
};

src/elements/common/sub-header/__tests__/SubHeaderLeftMetadataViewV2.test.tsx

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import SubHeaderLeftMetadataViewV2 from '../SubHeaderLeftMetadataViewV2';
99
interface SubHeaderLeftMetadataViewV2Props {
1010
api?: API;
1111
currentCollection: Collection;
12-
metadataAncestorFolderName?: string | null;
1312
metadataQuery?: MetadataQuery;
1413
metadataViewTitle?: string;
1514
onClearSelectedKeys?: () => void;
@@ -49,32 +48,10 @@ describe('elements/common/sub-header/SubHeaderLeftMetadataViewV2', () => {
4948
test('should render metadata view title when provided', () => {
5049
renderComponent({
5150
metadataViewTitle: 'Custom Metadata View',
52-
metadataAncestorFolderName: 'Test Folder',
5351
selectedKeys: new Set(),
5452
});
5553

56-
// Custom title should override ancestor folder name
5754
expect(screen.getByText('Custom Metadata View')).toBeInTheDocument();
58-
expect(screen.queryByText('Test Folder')).not.toBeInTheDocument();
59-
});
60-
61-
test('should render ancestor folder name when no metadata view title is provided', () => {
62-
renderComponent({
63-
metadataAncestorFolderName: 'Test Folder',
64-
selectedKeys: new Set(),
65-
});
66-
67-
expect(screen.getByText('Test Folder')).toBeInTheDocument();
68-
});
69-
70-
test('should handle null ancestor folder name gracefully', () => {
71-
renderComponent({
72-
metadataAncestorFolderName: null,
73-
selectedKeys: new Set(),
74-
});
75-
76-
// Should not crash and should not render any folder name
77-
expect(screen.queryByText('Test Folder')).not.toBeInTheDocument();
7855
});
7956
});
8057

src/elements/content-explorer/Content.tsx

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,8 @@ export interface ContentProps extends Required<ItemEventHandlers>, Required<Item
3636
isSmall: boolean;
3737
isTouch: boolean;
3838
itemActions?: ItemAction[];
39-
<<<<<<< HEAD
4039
metadataTemplate?: MetadataTemplate;
4140
metadataViewProps?: Omit<MetadataViewContainerProps, 'currentCollection'>;
42-
=======
43-
metadataProps?: Omit<MetadataViewContainerProps, 'currentCollection'>;
44-
>>>>>>> b49985c8b (feat(metadata-view): Add MetadataView V2)
4541
onMetadataUpdate: (
4642
item: BoxItem,
4743
field: string,
@@ -59,12 +55,8 @@ const Content = ({
5955
features,
6056
fieldsToShow = [],
6157
gridColumnCount,
62-
<<<<<<< HEAD
6358
metadataTemplate,
6459
metadataViewProps,
65-
=======
66-
metadataProps,
67-
>>>>>>> b49985c8b (feat(metadata-view): Add MetadataView V2)
6860
onMetadataUpdate,
6961
onSortChange,
7062
view,
@@ -96,13 +88,8 @@ const Content = ({
9688
currentCollection={currentCollection}
9789
isLoading={percentLoaded !== 100}
9890
hasError={view === VIEW_ERROR}
99-
<<<<<<< HEAD
10091
metadataTemplate={metadataTemplate}
10192
{...metadataViewProps}
102-
=======
103-
onSortChange={onSortChange}
104-
{...metadataProps}
105-
>>>>>>> b49985c8b (feat(metadata-view): Add MetadataView V2)
10693
/>
10794
)}
10895
{!isViewEmpty && isListView && (

src/elements/content-explorer/ContentExplorer.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1734,8 +1734,6 @@ class ContentExplorer extends Component<ContentExplorerProps, State> {
17341734
const hasNextMarker: boolean = !!markers[currentPageNumber + 1];
17351735
const hasPreviousMarker: boolean = currentPageNumber === 1 || !!markers[currentPageNumber - 1];
17361736

1737-
console.log({ currentCollection });
1738-
17391737
const combinedMetadataViewProps = {
17401738
...metadataViewProps,
17411739
tableProps: {
@@ -1772,6 +1770,7 @@ class ContentExplorer extends Component<ContentExplorerProps, State> {
17721770
gridMaxColumns={GRID_VIEW_MAX_COLUMNS}
17731771
gridMinColumns={GRID_VIEW_MIN_COLUMNS}
17741772
maxGridColumnCountForWidth={maxGridColumnCount}
1773+
metadataViewTitle={metadataViewTitle || metadataAncestorFolderName}
17751774
onUpload={this.upload}
17761775
onCreate={this.createFolder}
17771776
onGridViewSliderChange={this.onGridViewSliderChange}
@@ -1781,8 +1780,6 @@ class ContentExplorer extends Component<ContentExplorerProps, State> {
17811780
portalElement={this.rootElement}
17821781
selectedKeys={this.state.selectedKeys}
17831782
onClearSelectedKeys={this.handleClearSelectedKeys}
1784-
metadataAncestorFolderName={metadataAncestorFolderName}
1785-
metadataViewTitle={metadataViewTitle}
17861783
/>
17871784

17881785
<Content

0 commit comments

Comments
 (0)