From 9450d2588f450dc9699c33bdb340e7c19b15e659 Mon Sep 17 00:00:00 2001 From: aditsharma55 Date: Fri, 19 Dec 2025 18:32:15 +0530 Subject: [PATCH 1/2] Fix(BREV-2215): missing refid for shadeform --- v1/providers/shadeform/instance.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/v1/providers/shadeform/instance.go b/v1/providers/shadeform/instance.go index 6f4e089..ef3fb31 100644 --- a/v1/providers/shadeform/instance.go +++ b/v1/providers/shadeform/instance.go @@ -253,7 +253,7 @@ func (c *ShadeformClient) ListInstances(ctx context.Context, _ v1.ListInstancesA for _, instance := range resp.Instances { singleInstance, err := c.convertShadeformInstanceToV1Instance(instance) if err != nil { - return nil, errors.WrapAndTrace(err) + continue } instances = append(instances, *singleInstance) } @@ -357,13 +357,13 @@ func (c *ShadeformClient) convertShadeformInstanceToV1Instance(shadeformInstance refID, found := tags[refIDTagName] if !found { - return nil, errors.WrapAndTrace(errors.New("could not find refID tag")) + return nil, fmt.Errorf("instance missing refID tag: instanceID=%s, instanceName=%s", shadeformInstance.Id, shadeformInstance.Name) } delete(tags, refIDTagName) cloudCredRefID, found := tags[cloudCredRefIDTagName] if !found { - return nil, errors.WrapAndTrace(errors.New("could not find cloudCredRefID tag")) + return nil, fmt.Errorf("instance missing cloudCredRefID tag: instanceID=%s, instanceName=%s", shadeformInstance.Id, shadeformInstance.Name) } delete(tags, cloudCredRefIDTagName) From a764c9a7fef8d88b039786f91e25e3afaafef1fb Mon Sep 17 00:00:00 2001 From: aditsharma55 Date: Mon, 22 Dec 2025 20:10:10 +0530 Subject: [PATCH 2/2] Fix(BREV-2215): added warning logs --- v1/providers/shadeform/instance.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/v1/providers/shadeform/instance.go b/v1/providers/shadeform/instance.go index ef3fb31..372a9fb 100644 --- a/v1/providers/shadeform/instance.go +++ b/v1/providers/shadeform/instance.go @@ -253,6 +253,10 @@ func (c *ShadeformClient) ListInstances(ctx context.Context, _ v1.ListInstancesA for _, instance := range resp.Instances { singleInstance, err := c.convertShadeformInstanceToV1Instance(instance) if err != nil { + c.logger.Warn(ctx, "skipping instance without refID tag", + v1.LogField("instanceID", instance.Id), + v1.LogField("instanceName", instance.Name), + v1.LogField("error", err.Error())) continue } instances = append(instances, *singleInstance)