ci: use Github Actions, standard style

Author: goto-bus-stop

.github/dependabot.yml

@@ -0,0 +1,8 @@
+version: 2
+updates:
+- package-ecosystem: npm
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "04:00"
+  open-pull-requests-limit: 10

.github/workflows/ci.yml

@@ -0,0 +1,36 @@
+name: Node CI
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [4.x, 6.x, 8.x, 10.x, 12.x, 14.x, 16.x, 18.x]
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v3
+      with:
+        node-version: ${{ matrix.node-version }}
+    - name: npm install
+      run: npm install
+    - name: npm test
+      run: npm run tests-only
+
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Use Node.js LTS
+      uses: actions/setup-node@v3
+      with:
+        node-version: lts/*
+    - name: npm install
+      run: npm install
+    - name: npm run lint
+      run: npm run lint

.travis.yml

@@ -1,2 +1,2 @@
-var message = require('./xyz').getMessage()
+const message = require('./xyz').getMessage()
 console.log(message)

example/app.js

@@ -1,19 +1,19 @@
-var path = require('path')
-var browserify = require('browserify')
-var commonShake = require('../')
+const path = require('path')
+const browserify = require('browserify')
+const commonShake = require('../')
 
-var b = browserify({ entries: path.join(__dirname, 'app.js') })
+const b = browserify({ entries: path.join(__dirname, 'app.js') })
   .plugin(commonShake, {
     verbose: true
   })
   .bundle()
 
 // Minify & save
-var fs = require('fs')
-var concat = require('concat-stream')
-var uglify = require('uglify-js')
+const fs = require('fs')
+const concat = require('concat-stream')
+const uglify = require('uglify-js')
 b.pipe(concat(function (source) {
-  var minified = uglify.minify(source.toString('utf8'), {
+  const minified = uglify.minify(source.toString('utf8'), {
     mangle: false,
     compress: true
   })

example/build.js

@@ -1,4 +1,4 @@
-var target = exports.target = 'world'
+let target = exports.target = 'world'
 exports.getMessage = function () {
   return 'hello ' + target
 }

example/xyz.js

@@ -57,7 +57,7 @@ module.exports = function commonShake (b, opts) {
       aliases.set(id, file)
     })
     b.pipeline.get('label').unshift(createStream(opts, {
-      getSideEffects(name) {
+      getSideEffects (name) {
         const file = aliases.get(name) || name
         let pkg
         let dir = file
@@ -66,7 +66,7 @@ module.exports = function commonShake (b, opts) {
           pkg = packages.get(dir)
           prevDir = dir
         }
-        return pkg && pkg.sideEffects === false ? false : true
+        return !(pkg && pkg.sideEffects === false)
       }
     }))
   }
@@ -227,7 +227,7 @@ function createStream (opts, api) {
 
   function remove (string, node) {
     if (node.type === 'AssignmentExpression') {
-      var prefix = commentify(`${node.left.getSource()} =`) + ' '
+      let prefix = commentify(`${node.left.getSource()} =`) + ' '
       // Anonymous function and class expressions are parsed as statements if they
       // are the first thing in a statement, which can happen if the `exports.xyz`
       // assignment happened inside a SequenceExpression (usually after minification).
@@ -238,25 +238,25 @@ function createStream (opts, api) {
       // In the case of non-function/class expressions, we can void the whole thing
       // eg: `exports.a={},exports.b=''`
       // becomes: `void {},void ''`
-      var isFunction = node.right.type === 'FunctionExpression'
-      var isAssignment = node.right.type === 'AssignmentExpression'
-      var isArrowFunction = node.right.type === 'ArrowFunctionExpression'
-      var isVariableDeclarator = node.parent.parent.type === 'VariableDeclarator'
+      const isFunction = node.right.type === 'FunctionExpression'
+      const isAssignment = node.right.type === 'AssignmentExpression'
+      const isArrowFunction = node.right.type === 'ArrowFunctionExpression'
+      const isVariableDeclarator = node.parent.parent.type === 'VariableDeclarator'
       if (
-          // persist sequential variable declarations
-          // eg: `var a = (0, exports.a = function(){})`
-          (!isVariableDeclarator && node.parent.type === 'SequenceExpression') ||
+      // persist sequential variable declarations
+      // eg: `var a = (0, exports.a = function(){})`
+        (!isVariableDeclarator && node.parent.type === 'SequenceExpression') ||
           // without this, `exports.a = exports.b = xyz` eliminating exports.a becomes `void exports.b = xyz`
           // which is invalid.
           isAssignment ||
           // Don't output a statement containing only `void () => {}`
           isArrowFunction
-        ) {
+      ) {
         // ignore alias assignment expression `exports.a = exports.b = exports.c`
         // unless the last argument is noname function
-        var isAliasAssignment = isAssignment && node.right.left.type === 'MemberExpression' && node.right.left.object.name === 'exports'
-        var isAliasFunction = isAliasAssignment && node.right.right.type === 'FunctionExpression'
-        var isAliasClass = isAliasAssignment && node.right.right.type === 'ClassExpression'
+        const isAliasAssignment = isAssignment && node.right.left.type === 'MemberExpression' && node.right.left.object.name === 'exports'
+        const isAliasFunction = isAliasAssignment && node.right.right.type === 'FunctionExpression'
+        const isAliasClass = isAliasAssignment && node.right.right.type === 'ClassExpression'
         if (!isAliasAssignment || isAliasFunction || isAliasClass) {
           prefix += 'void '
           if (isAssignment || isArrowFunction || isFunction || isAliasFunction || isAliasClass) {

index.js

@@ -4,7 +4,9 @@
   "description": "browserify tree shaking plugin using @indutny common-shake",
   "main": "index.js",
   "scripts": {
-    "test": "tape test/test.js"
+    "lint": "standard",
+    "tests-only": "tape test/test.js",
+    "test": "npm run lint && npm run tests-only"
   },
   "repository": {
     "type": "git",
@@ -40,7 +42,14 @@
     "browserify": "^16.1.1",
     "concat-stream": "^1.6.1",
     "net-browserify-stub": "0.0.1",
+    "standard": "^17.0.0",
     "tape": "^4.9.0",
     "uglify-js": "^3.3.15"
+  },
+  "standard": {
+    "ignore": [
+      "test/*/*.js",
+      "example/bundle.*"
+    ]
   }
 }

package.json

@@ -1,9 +1,9 @@
-var test = require('tape')
-var path = require('path')
-var browserify = require('browserify')
-var commonShakeify = require('../')
+const test = require('tape')
+const path = require('path')
+const browserify = require('browserify')
+const commonShakeify = require('../')
 
-var sampleEntry = path.join(__dirname, 'simple/app.js')
+const sampleEntry = path.join(__dirname, 'simple/app.js')
 
 test('should work as a plugin', function (t) {
   try {

test/api.js

@@ -1,21 +1,21 @@
-var test = require('tape')
-var assert = require('assert')
-var fs = require('fs')
-var path = require('path')
-var browserify = require('browserify')
-var concat = require('concat-stream')
-var commonShake = require('../')
+const test = require('tape')
+const assert = require('assert')
+const fs = require('fs')
+const path = require('path')
+const browserify = require('browserify')
+const concat = require('concat-stream')
+const commonShake = require('../')
 
 function runTest (t, name) {
   t.plan(1)
-  var basedir = path.join(__dirname, name)
-  var optionsPath = path.join(basedir, 'options.js')
-  var options = {}
+  const basedir = path.join(__dirname, name)
+  const optionsPath = path.join(basedir, 'options.js')
+  let options = {}
   try { options = require(optionsPath)(t) } catch (err) {}
-  var entry = path.join(basedir, 'app.js')
-  var expected = path.join(basedir, 'expected.js')
-  var actual = path.join(basedir, 'actual.js')
-  var bundle = browserify({ entries: entry })
+  const entry = path.join(basedir, 'app.js')
+  const expected = path.join(basedir, 'expected.js')
+  const actual = path.join(basedir, 'actual.js')
+  const bundle = browserify({ entries: entry })
     .plugin(commonShake, options)
     .bundle()
     .on('error', t.fail)
@@ -74,7 +74,7 @@ test('side-effects', function (t) {
 })
 
 test('external', function (t) {
-  var b = browserify({
+  const b = browserify({
     entries: path.join(__dirname, 'external/app.js')
   })
 
@@ -87,7 +87,7 @@ test('external', function (t) {
 })
 
 test('source maps', function (t) {
-  var b = browserify({
+  const b = browserify({
     entries: path.join(__dirname, 'source-map/app.js'),
     debug: true,
     preludePath: 'node_modules/browser-pack/_prelude.js'
@@ -99,7 +99,7 @@ test('source maps', function (t) {
   })
   b.plugin(commonShake)
 
-  var bundle = b.bundle()
+  const bundle = b.bundle()
   bundle.on('error', t.fail)
 
   // Write actual output to a file for easier inspection
@@ -118,13 +118,13 @@ test('source maps', function (t) {
 })
 
 test('dash-r', function (t) {
-  var b = browserify({
+  const b = browserify({
     entries: path.join(__dirname, 'dash-r/app.js')
   })
   b.require(path.join(__dirname, 'dash-r/expose.js'), { expose: 'whatever' })
   b.plugin(commonShake)
 
-  var bundle = b.bundle()
+  const bundle = b.bundle()
   bundle.on('error', t.fail)
 
   bundle.pipe(fs.createWriteStream(
@@ -142,13 +142,13 @@ test('dash-r', function (t) {
 })
 
 test('dash-r node_modules', function (t) {
-  var b = browserify({
+  const b = browserify({
     entries: path.join(__dirname, 'dash-r-node-modules/app.js')
   })
   b.require('net-browserify-stub', { expose: 'net' })
   b.plugin(commonShake)
 
-  var bundle = b.bundle()
+  const bundle = b.bundle()
   bundle.on('error', t.fail)
 
   bundle.pipe(fs.createWriteStream(
@@ -167,14 +167,14 @@ test('dash-r node_modules', function (t) {
 
 // TODO fix this one
 test('dash-r node_modules with full paths', { skip: true }, function (t) {
-  var b = browserify({
+  const b = browserify({
     fullPaths: true,
     entries: path.join(__dirname, 'dash-r-node-modules/app.js')
   })
   b.require('net-browserify-stub', { expose: 'net' })
   b.plugin(commonShake)
 
-  var bundle = b.bundle()
+  const bundle = b.bundle()
   bundle.on('error', t.fail)
 
   bundle.pipe(fs.createWriteStream(