Merge pull request #394 from bugsnag/utcnow-deprecated

replace utcnow calls

Author: clr182

CHANGELOG.md

@@ -1,6 +1,13 @@
 Changelog
 =========
 
+## TBD 
+
+### Enhancements
+
+* Remove depricated `datetime.utcnow()` method call from utils class
+  [#394](https://github.com/bugsnag/bugsnag-python/pull/394).
+
 ## v4.7.1 (2024-05-22)
 
 ### Bug fixes

bugsnag/utils.py

@@ -4,6 +4,7 @@
 from threading import local as threadlocal
 from typing import AnyStr, Tuple, Optional
 import warnings
+import sys
 import copy
 import logging
 from datetime import datetime, timedelta
@@ -422,14 +423,13 @@ def remove_query_from_url(url: AnyStr) -> Optional[AnyStr]:
 # milliseconds precision
 # Python can do this natively from version 3.6, but we need to include a
 # fallback implementation for Python 3.5
-try:
-    # this will raise if 'timespec' isn't supported
-    datetime.utcnow().isoformat(timespec='milliseconds')  # type: ignore
-
+if sys.version_info >= (3, 6):
+    # Python 3.6+ has a built-in method for this
     def to_rfc3339(dt: datetime) -> str:
         return dt.isoformat(timespec='milliseconds')  # type: ignore
 
-except Exception:
+else:
+    # Python 3.5 fallback implementation
     def _get_timezone_offset(dt: datetime) -> str:
         if dt.tzinfo is None:
             return ''
@@ -464,17 +464,16 @@ def to_rfc3339(dt: datetime) -> str:
 
 
 def get_package_version(package_name: str) -> Optional[str]:
-    try:
-        from importlib import metadata
-
-        return metadata.version(package_name)  # type: ignore
-    except ImportError:
+    if sys.version_info >= (3, 8):
         try:
-            import pkg_resources
-        except ImportError:
+            from importlib import metadata
+            return metadata.version(package_name)  # type: ignore
+        except metadata.PackageNotFoundError:
             return None
-
+    else:
         try:
-            return pkg_resources.get_distribution(package_name).version
-        except pkg_resources.DistributionNotFound:
+            import pkg_resources  # type: ignore
+            return pkg_resources.get_distribution(
+                package_name).version  # type: ignore
+        except (ImportError, pkg_resources.DistributionNotFound):
             return None

tox.ini

@@ -65,6 +65,7 @@ deps=
     exceptiongroup: exceptiongroup
     lint: flake8
     lint: mypy
+    lint: types-pkg_resources; python_version < '3.12'
     lint: types-setuptools
     lint: types-requests
     lint: types-Flask