[TE-4628] Remove CI environment variable requirement for uploads

The presence of BUILDKITE_ANALYTICS_TOKEN is sufficient to determine
upload intent. Previously, both CI and token were required, which caused
issues for users who carefully manage environment variables in isolated
container environments.

This change removes the CI check from the API.submit() method while
preserving the self.ci attribute for potential future use. Now only
BUILDKITE_ANALYTICS_TOKEN determines whether uploads happen.

Fixes #74

Author: gchan

src/buildkite_test_collector/collector/api.py

@@ -29,9 +29,6 @@ def submit(self, payload: Payload, batch_size=100) -> Generator[Optional[Respons
         """Submit a payload to the API"""
         response = None
 
-        if not self.ci:
-            yield None
-
         if not self.token:
             logger.warning("No %s environment variable present", self.ENV_TOKEN)
             yield None

tests/buildkite_test_collector/collector/test_api.py

@@ -12,14 +12,16 @@
 from requests.exceptions import ReadTimeout, ConnectTimeout
 
 def test_submit_local_returns_none(capfd):
-    env = {"CI": None}
+    """Verify that submit returns None and logs warning when token is missing"""
+    env = {"CI": None, "BUILDKITE_ANALYTICS_TOKEN": None}
     payload = Payload.init(RunEnvBuilder(env).build())
 
     api = API(env)
     assert next(api.submit(payload)) is None
     captured = capfd.readouterr()
 
-    assert not captured.err.startswith("buildkite-test-collector - WARNING -")
+    assert captured.err.startswith("buildkite-test-collector - WARNING -")
+    assert "BUILDKITE_ANALYTICS_TOKEN" in captured.err
 
 def test_submit_with_missing_api_key_environment_variable_returns_none(capfd):
     env = {"CI": "true", "BUILDKITE_ANALYTICS_TOKEN": None}
@@ -84,6 +86,37 @@ def test_submit_with_payload_timeout_captures_ReadTimeout_error(capfd, successfu
     assert captured.err.startswith("buildkite-test-collector - WARNING -")
     assert "ReadTimeout" in captured.err
 
+@responses.activate
+def test_submit_with_token_uploads_without_ci(successful_test):
+    """Verify that uploads work when token is present but CI variable is not set"""
+    responses.add(
+        responses.POST,
+        "https://analytics-api.buildkite.com/v1/uploads",
+        json={'id': str(uuid4()),
+              'run_id': str(uuid4()),
+              'queued': 1,
+              'skipped': 0,
+              'errors': [],
+              'run_url': 'https://buildkite.com/organizations/alembic/analytics/suites/test/runs/52c5d9f6-a4f2-4a2d-a1e6-993335789c92'},
+        status=202)
+
+    # Note: CI is explicitly not set in environment
+    env = {"BUILDKITE_ANALYTICS_TOKEN": str(uuid4())}
+    payload = Payload.init(RunEnvBuilder(env).build())
+    payload = payload.started()
+    payload = payload.push_test_data(successful_test)
+
+    api = API(env)
+    result = next(api.submit(payload))
+
+    assert result is not None
+    assert result.status_code >= 200
+    assert result.status_code < 300
+
+    json_response = result.json()
+    assert len(json_response["errors"]) == 0
+    assert json_response['queued'] == 1
+
 @responses.activate
 def test_submit_with_payload_returns_an_api_response(successful_test):
     responses.add(