Skip to content

Commit 819234f

Browse files
fix(p3-shim): flaky http client test server creation
1 parent 13a7980 commit 819234f

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

packages/preview3-shim/test/http/client.test.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,16 @@ describe('HttpClient Integration', () => {
3131
server = http.createServer((req, res) => {
3232
if (req.url === '/error') {
3333
res.statusCode = 500;
34-
return res.end(JSON.stringify({ error: 'Server error' }));
34+
res.end(JSON.stringify({ error: 'Server error' }));
35+
return;
3536
}
3637

3738
if (req.url === '/delayed-first-byte') {
38-
return setTimeout(() => {
39+
setTimeout(() => {
3940
res.writeHead(200, { 'Content-Type': 'text/plain' });
4041
res.end('ok');
4142
}, 200);
43+
return;
4244
}
4345

4446
res.setHeader('Content-Type', 'application/json');
@@ -57,11 +59,13 @@ describe('HttpClient Integration', () => {
5759
res.end(responseBody);
5860
});
5961
});
60-
61-
const host = '127.0.0.1';
62-
const port = await getRandomPort();
63-
authority = `${host}:${port}`;
64-
server.listen(port);
62+
63+
await new Promise((resolve) => {
64+
server.listen(0, function() {
65+
authority = `127.0.0.1:${this.address().port}`;
66+
resolve(null);
67+
});
68+
});
6569
});
6670

6771
afterAll(async () => {

0 commit comments

Comments
 (0)