diff --git a/.jules/bolt.md b/.jules/bolt.md new file mode 100644 index 0000000..e50daaa --- /dev/null +++ b/.jules/bolt.md @@ -0,0 +1,3 @@ +## 2024-05-24 - Offloading Blocking Tasks from @MainActor +**Learning:** In Swift, synchronous, blocking operations like `Foundation.Process.waitUntilExit()`, `readDataToEndOfFile()`, and `DiskInfo.current()` will freeze the UI if executed within an `@MainActor` context (like a ViewModel). +**Action:** Use `await Task.detached { ... }.value` to offload these blocking operations to a background thread, preventing UI unresponsiveness and adhering to structured concurrency best practices. \ No newline at end of file diff --git a/Sources/Cacheout/ViewModels/CacheoutViewModel.swift b/Sources/Cacheout/ViewModels/CacheoutViewModel.swift index 13a9811..39b68e8 100644 --- a/Sources/Cacheout/ViewModels/CacheoutViewModel.swift +++ b/Sources/Cacheout/ViewModels/CacheoutViewModel.swift @@ -147,7 +147,7 @@ class CacheoutViewModel: ObservableObject { func scan() async { isScanning = true isNodeModulesScanning = true - diskInfo = DiskInfo.current() + diskInfo = await Task.detached { DiskInfo.current() }.value // Scan caches and node_modules in parallel async let cacheResults = scanner.scanAll(CacheCategory.allCategories) @@ -241,10 +241,12 @@ class CacheoutViewModel: ObservableObject { ] do { - try process.run() - process.waitUntilExit() - let data = pipe.fileHandleForReading.readDataToEndOfFile() - let output = String(data: data, encoding: .utf8) ?? "" + let output: String = try await Task.detached { + try process.run() + process.waitUntilExit() + let data = pipe.fileHandleForReading.readDataToEndOfFile() + return String(data: data, encoding: .utf8) ?? "" + }.value if process.terminationStatus == 0 { // Extract "Total reclaimed space:" line @@ -270,7 +272,7 @@ class CacheoutViewModel: ObservableObject { } // Refresh disk info after prune - diskInfo = DiskInfo.current() + diskInfo = await Task.detached { DiskInfo.current() }.value } func clean() async {