From 8de32ed3e2f8ed71bcc53f04927b433b45f824d3 Mon Sep 17 00:00:00 2001 From: Brian Love Date: Fri, 15 May 2026 13:32:14 -0700 Subject: [PATCH] ci: silence playwright webkit-deps warning and drop orphaned worktree gitlinks Two unrelated CI-log cleanups that frequently confuse PR reviewers. 1. apps/cockpit/playwright.config.ts and apps/website/playwright.config.ts now declare chromium as the only project. Without a projects array, Playwright validates ALL default browsers (chromium + webkit + firefox) on test start and prints a 30-line 'missing system dependencies' warning for the browsers CI doesn't install. Tests run on chromium and pass; the warning is pure noise. 2. Two stray gitlinks under .claude/worktrees/ (website-iteration, zealous-jones) were committed as submodule entries but .gitmodules doesn't exist. Post-job actions/checkout cleanup prints 'fatal: No url found for submodule path' and exits 128 (caught as a warning). .gitignore already excludes .claude/worktrees/ so these don't reappear. --- .claude/worktrees/website-iteration | 1 - .claude/worktrees/zealous-jones | 1 - apps/cockpit/playwright.config.ts | 12 +++++++++++- apps/website/playwright.config.ts | 11 ++++++++++- 4 files changed, 21 insertions(+), 4 deletions(-) delete mode 160000 .claude/worktrees/website-iteration delete mode 160000 .claude/worktrees/zealous-jones diff --git a/.claude/worktrees/website-iteration b/.claude/worktrees/website-iteration deleted file mode 160000 index 510befe14..000000000 --- a/.claude/worktrees/website-iteration +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 510befe14ac3482c89f883f52821604f143fa5f2 diff --git a/.claude/worktrees/zealous-jones b/.claude/worktrees/zealous-jones deleted file mode 160000 index 413d3fa51..000000000 --- a/.claude/worktrees/zealous-jones +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 413d3fa51304735e59092675750c26631dab4ee1 diff --git a/apps/cockpit/playwright.config.ts b/apps/cockpit/playwright.config.ts index d4b895eec..5f1f45101 100644 --- a/apps/cockpit/playwright.config.ts +++ b/apps/cockpit/playwright.config.ts @@ -1,4 +1,4 @@ -import { defineConfig } from '@playwright/test'; +import { defineConfig, devices } from '@playwright/test'; const baseURL = process.env['BASE_URL'] ?? 'http://127.0.0.1:4201'; const shouldStartLocalServer = !process.env['BASE_URL']; @@ -10,6 +10,16 @@ export default defineConfig({ use: { baseURL, }, + // Declare chromium as the only browser project. Without this, Playwright + // validates ALL default browsers (chromium + webkit + firefox) on test + // start and prints a long "missing system dependencies" warning for the + // browsers we don't run, even though tests pass cleanly on chromium. + projects: [ + { + name: 'chromium', + use: { ...devices['Desktop Chrome'] }, + }, + ], webServer: shouldStartLocalServer ? { command: 'npx next dev . --port 4201', diff --git a/apps/website/playwright.config.ts b/apps/website/playwright.config.ts index 3b8744417..bf2c7a264 100644 --- a/apps/website/playwright.config.ts +++ b/apps/website/playwright.config.ts @@ -1,4 +1,4 @@ -import { defineConfig } from '@playwright/test'; +import { defineConfig, devices } from '@playwright/test'; const localHost = '127.0.0.1'; const localPort = process.env['WEBSITE_E2E_PORT'] ?? '4308'; @@ -13,6 +13,15 @@ export default defineConfig({ use: { baseURL, }, + // Declare chromium as the only browser project — see the matching comment + // in apps/cockpit/playwright.config.ts. Suppresses the misleading + // "missing system dependencies" warning for webkit/firefox. + projects: [ + { + name: 'chromium', + use: { ...devices['Desktop Chrome'] }, + }, + ], webServer: shouldStartLocalServer ? { command: `npx next dev . --hostname ${localHost} --port ${localPort}`,