Changed WorkerOption to fallback and use WorkflowClient tracer instead of NoopTracer (#883)

What changed?

WorkflowOptions will now fallback and use WorkflowClient's tracer.
Expose getOptions on IWorkflowService interface.
Why?

Make it easier to set tracer. Previously, it's required to set tracer both on the client and worker. Now setting tracer only on client should just work.

How did you test it?

Unit Test

Author: shijiesheng

src/main/java/com/uber/cadence/internal/compatibility/Thrift2ProtoAdapter.java

@@ -103,6 +103,7 @@
 import com.uber.cadence.internal.compatibility.proto.serviceclient.IGrpcServiceStubs;
 import com.uber.cadence.internal.compatibility.thrift.ErrorMapper;
 import com.uber.cadence.internal.compatibility.thrift.ResponseMapper;
+import com.uber.cadence.serviceclient.ClientOptions;
 import com.uber.cadence.serviceclient.IWorkflowService;
 import io.grpc.Deadline;
 import io.grpc.StatusRuntimeException;
@@ -121,6 +122,11 @@ public Thrift2ProtoAdapter(IGrpcServiceStubs grpcServiceStubs) {
     this.grpcServiceStubs = grpcServiceStubs;
   }
 
+  @Override
+  public ClientOptions getOptions() {
+    return grpcServiceStubs.getOptions();
+  }
+
   @Override
   public void RegisterDomain(RegisterDomainRequest registerRequest)
       throws BadRequestError, DomainAlreadyExistsError, ServiceBusyError,

src/main/java/com/uber/cadence/internal/compatibility/proto/serviceclient/GrpcServiceStubs.java

@@ -81,6 +81,7 @@ final class GrpcServiceStubs implements IGrpcServiceStubs {
 
   private static final String CLIENT_IMPL_HEADER_VALUE = "uber-java";
 
+  private final ClientOptions options;
   private final ManagedChannel channel;
   private final boolean shutdownChannel;
   private final AtomicBoolean shutdownRequested = new AtomicBoolean();
@@ -96,6 +97,7 @@ final class GrpcServiceStubs implements IGrpcServiceStubs {
   private final MetaAPIGrpc.MetaAPIFutureStub metaFutureStub;
 
   GrpcServiceStubs(ClientOptions options) {
+    this.options = options;
     if (options.getGRPCChannel() != null) {
       this.channel = options.getGRPCChannel();
       shutdownChannel = false;
@@ -290,6 +292,11 @@ public DomainAPIGrpc.DomainAPIFutureStub domainFutureStub() {
     return domainFutureStub;
   }
 
+  @Override
+  public ClientOptions getOptions() {
+    return options;
+  }
+
   @Override
   public VisibilityAPIBlockingStub visibilityBlockingStub() {
     return visibilityBlockingStub;

src/main/java/com/uber/cadence/internal/compatibility/proto/serviceclient/IGrpcServiceStubs.java

@@ -39,6 +39,8 @@ static IGrpcServiceStubs newInstance(ClientOptions options) {
     return new GrpcServiceStubs(options);
   }
 
+  ClientOptions getOptions();
+
   /** @return Blocking (synchronous) stub to domain service. */
   DomainAPIGrpc.DomainAPIBlockingStub domainBlockingStub();
 

src/main/java/com/uber/cadence/internal/sync/TestActivityEnvironmentInternal.java

@@ -26,6 +26,7 @@
 import com.uber.cadence.internal.metrics.NoopScope;
 import com.uber.cadence.internal.worker.ActivityTaskHandler;
 import com.uber.cadence.internal.worker.ActivityTaskHandler.Result;
+import com.uber.cadence.serviceclient.ClientOptions;
 import com.uber.cadence.serviceclient.IWorkflowService;
 import com.uber.cadence.testing.TestActivityEnvironment;
 import com.uber.cadence.testing.TestEnvironmentOptions;
@@ -323,6 +324,11 @@ private class WorkflowServiceWrapper implements IWorkflowService {
 
     private final IWorkflowService impl;
 
+    @Override
+    public ClientOptions getOptions() {
+      return impl.getOptions();
+    }
+
     @Override
     public CompletableFuture<Boolean> isHealthy() {
       return impl.isHealthy();

src/main/java/com/uber/cadence/internal/sync/TestWorkflowEnvironmentInternal.java

@@ -104,6 +104,7 @@
 import com.uber.cadence.client.WorkflowOptions;
 import com.uber.cadence.client.WorkflowStub;
 import com.uber.cadence.internal.testservice.TestWorkflowService;
+import com.uber.cadence.serviceclient.ClientOptions;
 import com.uber.cadence.serviceclient.IWorkflowService;
 import com.uber.cadence.testing.TestEnvironmentOptions;
 import com.uber.cadence.testing.TestWorkflowEnvironment;
@@ -278,6 +279,11 @@ public long currentTimeMillis() {
       return impl.currentTimeMillis();
     }
 
+    @Override
+    public ClientOptions getOptions() {
+      return impl.getOptions();
+    }
+
     @Override
     public RecordActivityTaskHeartbeatResponse RecordActivityTaskHeartbeat(
         RecordActivityTaskHeartbeatRequest heartbeatRequest) throws TException {

src/main/java/com/uber/cadence/internal/testservice/TestWorkflowService.java

@@ -105,6 +105,7 @@
 import com.uber.cadence.WorkflowIdReusePolicy;
 import com.uber.cadence.internal.testservice.TestWorkflowMutableStateImpl.QueryId;
 import com.uber.cadence.internal.testservice.TestWorkflowStore.WorkflowState;
+import com.uber.cadence.serviceclient.ClientOptions;
 import com.uber.cadence.serviceclient.IWorkflowService;
 import java.time.Duration;
 import java.util.HashMap;
@@ -147,6 +148,11 @@ public void close() {
     store.close();
   }
 
+  @Override
+  public ClientOptions getOptions() {
+    return ClientOptions.defaultInstance();
+  }
+
   private TestWorkflowMutableState getMutableState(ExecutionId executionId)
       throws InternalServiceError, EntityNotExistsError {
     return getMutableState(executionId, true);

src/main/java/com/uber/cadence/migration/MigrationIWorkflowService.java

@@ -19,6 +19,7 @@
 
 import com.google.common.base.Strings;
 import com.uber.cadence.*;
+import com.uber.cadence.serviceclient.ClientOptions;
 import com.uber.cadence.serviceclient.IWorkflowService;
 import com.uber.cadence.serviceclient.IWorkflowServiceBase;
 import java.util.Arrays;
@@ -46,6 +47,11 @@ public MigrationIWorkflowService(
     this.domainNew = domainNew;
   }
 
+  @Override
+  public ClientOptions getOptions() {
+    return serviceOld.getOptions();
+  }
+
   @Override
   public StartWorkflowExecutionResponse StartWorkflowExecution(
       StartWorkflowExecutionRequest startRequest) throws TException {

src/main/java/com/uber/cadence/serviceclient/IWorkflowService.java

@@ -30,6 +30,8 @@
 public interface IWorkflowService extends Iface, AsyncIface {
   void close();
 
+  ClientOptions getOptions();
+
   /**
    * StartWorkflowExecutionWithTimeout start workflow same as StartWorkflowExecution but with
    * timeout

src/main/java/com/uber/cadence/serviceclient/IWorkflowServiceBase.java

@@ -24,6 +24,11 @@
 
 public class IWorkflowServiceBase implements IWorkflowService {
 
+  @Override
+  public ClientOptions getOptions() {
+    throw new IllegalArgumentException("unimplemented");
+  }
+
   @Override
   public void RegisterDomain(RegisterDomainRequest registerRequest)
       throws BadRequestError, DomainAlreadyExistsError, ServiceBusyError,

src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java

@@ -174,6 +174,11 @@ private <T> ThriftRequest<T> buildThriftRequest(String apiName, T body) {
     return buildThriftRequest(apiName, body, null);
   }
 
+  @Override
+  public ClientOptions getOptions() {
+    return options;
+  }
+
   /**
    * Checks if we have a valid connection to the Cadence cluster, and potentially resets the peer
    * list